added test for virtual columns support

ernetas · Apr 10, 2017 · 480edcf · 480edcf
1 parent 4321f0b
commit 480edcf
Show file tree

Hide file tree

Showing 3 changed files with 63 additions and 2 deletions.
diff --git a/src/Ifsnop/Mysqldump/Mysqldump.php b/src/Ifsnop/Mysqldump/Mysqldump.php
@@ -880,6 +880,8 @@ private function listValues($tableName)
                         implode("`, `", array_keys($this->tableColumnTypes[$tableName])) .
                         "`) VALUES (" . implode(",", $vals) . ")"
                     );
+                    // ojo, no debería ser array_keys, puesto que hemos eliminado algunos nombres de columnas en getcolumnsttmt!!
+                    // getcolumnstmt debería devolver un array, y así hacer implodes dos veces.
                 } else {
                     $lineSize += $this->compressManager->write(
                         "INSERT INTO `$tableName` VALUES (" . implode(",", $vals) . ")"

diff --git a/tests/test.php b/tests/test.php
@@ -87,7 +87,14 @@
     "mysql:unix_socket=/var/run/mysqld/mysqld.sock;dbname=test011",
     "travis",
     "",
-    array());
-$dump->start("mysqldump-php_test011.sql");
+    array('complete-insert' =>  false));
+$dump->start("mysqldump-php_test011a.sql");
+
+$dump = new IMysqldump\Mysqldump(
+    "mysql:unix_socket=/var/run/mysqld/mysqld.sock;dbname=test011",
+    "travis",
+    "",
+    array('complete-insert' =>  true));
+$dump->start("mysqldump-php_test011b.sql");
 
 exit;
diff --git a/tests/test011.src.sql b/tests/test011.src.sql
@@ -0,0 +1,52 @@
+DROP DATABASE IF EXISTS `test011`;
+CREATE DATABASE `test011`;
+USE `test011`;
+
+-- MySQL dump 10.13  Distrib 5.7.15, for Linux (x86_64)
+--
+-- Host: localhost    Database: test
+-- ------------------------------------------------------
+-- Server version       5.7.15
+
+/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
+/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
+/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
+/*!40101 SET NAMES utf8 */;
+/*!40103 SET @OLD_TIME_ZONE=@@TIME_ZONE */;
+/*!40103 SET TIME_ZONE='+00:00' */;
+/*!40014 SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS, UNIQUE_CHECKS=0 */;
+/*!40014 SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS, FOREIGN_KEY_CHECKS=0 */;
+/*!40101 SET @OLD_SQL_MODE=@@SQL_MODE, SQL_MODE='NO_AUTO_VALUE_ON_ZERO' */;
+/*!40111 SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0 */;
+
+--
+-- Table structure for table `test011`
+--
+
+DROP TABLE IF EXISTS `test011`;
+/*!40101 SET @saved_cs_client     = @@character_set_client */;
+/*!40101 SET character_set_client = utf8 */;
+CREATE TABLE `test011` (
+  `id` int(11) NOT NULL,
+  `hash` char(32) CHARACTER SET ascii COLLATE ascii_bin GENERATED ALWAYS AS (md5(`id`)) STORED NOT NULL
+) ENGINE=InnoDB DEFAULT CHARSET=utf8 ROW_FORMAT=DYNAMIC;
+/*!40101 SET character_set_client = @saved_cs_client */;
+
+--
+-- Dumping data for table `test011`
+--
+
+LOCK TABLES `test011` WRITE;
+/*!40000 ALTER TABLE `test011` DISABLE KEYS */;
+INSERT INTO `test011` (`id`) VALUES (159413),(294775);
+/*!40000 ALTER TABLE `test011` ENABLE KEYS */;
+UNLOCK TABLES;
+/*!40103 SET TIME_ZONE=@OLD_TIME_ZONE */;
+
+/*!40101 SET SQL_MODE=@OLD_SQL_MODE */;
+/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */;
+/*!40014 SET UNIQUE_CHECKS=@OLD_UNIQUE_CHECKS */;
+/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;
+/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;
+/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;
+/*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;