-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn this into a real JS package #2
base: master
Are you sure you want to change the base?
Conversation
…ve properly within the package.
…le for inclusion in a website.
Hello, and thank you for your effort! I also wanted to avoid a double documentation in form of README and the manual, that’s why the readme is just a link to the full documentation. But you are right: the standalone / install / build section could need some extra love. I added a MAKEFILE for minifying, even if it relies on globally installed npm packages it could quickly be adapted to local paths or to alternate build systems. Maybe a bit old-school… Unfortunately for now I can’t change the import paths as they are used on the playground as well: ES6 modules are loaded trough a hack in the live-code environment and module paths used in the user- and example-scripts need to be absolute (I think it also makes more sense from a “playground” perspective to see an absolute path vs. “../../“ in the code). Again, thank you for the precious inputs, I’m still reflecting on them…! |
I think the ability to distribute can only help. Why not do this? We could contribute and help you get the paths updated without breaking the playground. This is a seriously cool tool. Not being able to use it as a dependency makes it a bit odd in today's world and hard to maintain the project that is using it. Hope you take that into account and move to merge this. |
These changes turn this project into a first-class JS package! These changes include:
package.json
npm
Probably a good question for discussion:
play.core
the right name for this package if it gets published to NPM?Love this project!