Perparing for 1.0.0

CHANGELOG.md

@@ -4,15 +4,15 @@ CHANGELOG
 1.0.0
 -----
 
-TBD
+2014-09-24
 
 Major release
 
-* Module-wide change: This and all future versions of the module are now distributed under the Apache Licence v2.0! Previous versions are still licensed under the GNU General Public Licence v3.
+* Module-wide changes -- This and all future versions of the module are now distributed under the Apache Licence v2.0! Previous versions are still licensed under the GNU General Public Licence v3.
+                      -- This module is now dependant on [PuppetLabs' stdlib module](https://github.come/puppetlabs/puppetlabs-stdlib). Please make sure this module is available within your Puppet codebase.
 
 * vmwaretools fact -- Fixes vmwaretools fact detection for failed tools installs - thanks [Markus Frosch](https://github.com/lazyfrosch) for [pull request #49](https://github.com/craigwatson/puppet-vmwaretools/pull/49)!
 * vmwaretools      -- open-vm-tools is now purged rather than just absent thanks [Markus Frosch](https://github.com/lazyfrosch) for [pull request #49](https://github.com/craigwatson/puppet-vmwaretools/pull/49)!
-                   -- We now use PuppetLabs' [stdlib](https://github.come/puppetlabs/puppetlabs-stdlib) to validate parameters passed to the module
 
 0.4.3
 -----

README.md

@@ -44,8 +44,9 @@ Upgrading of currently installed VMware Tools packages is also supported - the m
 
 ###Setup Requirements
 
-* Perl must be installed on the target systems in order to run the VMware Tools installer.
+* Perl must be installed on the target systems in order to run the VMware Tools installer - installation of Perl is not handled by the module.
 * Pluginsync must be enabled, due to the `vmwaretools_version` custom fact distributed with this module. If the module cannot access the fact, the Puppet run will fail.
+* As of version 1.0.0, the module requires the [PuppetLabs stdlib module](https://github.come/puppetlabs/puppetlabs-stdlib) module to be available within your Puppet code.
 
 ###Beginning with puppet-vmwaretools	
 

Rakefile

@@ -9,11 +9,15 @@ begin
 rescue LoadError
 end
 
-PuppetLint.configuration.relative = true
-PuppetLint.configuration.send("disable_80chars")
-PuppetLint.configuration.send('disable_quoted_booleans')
-PuppetLint.configuration.log_format = "%{path}:%{linenumber}:%{check}:%{KIND}:%{message}"
 PuppetLint.configuration.fail_on_warnings = true
+PuppetLint.configuration.relative
+PuppetLint.configuration.send('disable_80chars')
+PuppetLint.configuration.send('disable_class_inherits_from_params_class')
+PuppetLint.configuration.send('disable_class_parameter_defaults')
+PuppetLint.configuration.send('disable_documentation')
+PuppetLint.configuration.send('disable_single_quote_string_with_variables')
+PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"]
+PuppetLint.configuration.log_format = "%{path}:%{linenumber}:%{check}:%{KIND}:%{message}"
 
 # Forsake support for Puppet 2.6.2 for the benefit of cleaner code.
 # http://puppet-lint.com/checks/class_parameter_defaults/

manifests/init.pp

@@ -115,7 +115,7 @@
   # https://tickets.puppetlabs.com/browse/FACT-151
   # https://projects.puppetlabs.com/issues/3704
 
-  if $::is_virtual == 'true' and $::virtual == 'vmware' and $::kernel == 'Linux' {
+  if $::is_virtual == true and $::virtual == 'vmware' and $::kernel == 'Linux' {
 
     if $::vmwaretools_version == undef {
       fail 'vmwaretools_version fact not present, please check your pluginsync configuraton.'
@@ -143,7 +143,7 @@
     if $timesync != undef {
       include vmwaretools::timesync
     }
-  } elsif $fail_on_non_vmware == true and ($::is_virtual == 'false' or $::virtual != 'vmware') {
+  } elsif $fail_on_non_vmware == true and ($::is_virtual == false or $::virtual != 'vmware') {
     fail 'Not a VMware platform.'
   }
 }