Implement bind 2.0 #137
Closed
Implement bind 2.0 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadgetci
reviewed
Mar 29, 2017
src/escalus_session.erl
Outdated
| JID = exml_query:path(BindReply, [{element, <<"bind">>}, {element, <<"jid">>}, cdata]), | ||
| Conn2 = Conn#client{jid = JID}, | ||
|
|
||
| PropsWithResource = |
There was a problem hiding this comment.
According to Elvis:
Line 249 has a tab at column 0.
bind/2 is not needed so the implementatino was moved to bind/3 Additionaly bind/3 returns client data with jid set based on the result of bind query
the previous recive was too strict, it was pattern maching on whole connection object which may be different for the process holding the connection and the one using it. F.e one has field jid set correctly, the other doesn't
|
Old PR, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes include:
escalus_session:bind/2- it is not neededescalus_session:bind/3returns client data with jid set based on the result of bind query