Improve escalus_bosh's handling of session termination #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an
escalus_bosh
connection in keepalive mode received a terminate reply from the server, it would send an empty keepalive response back to the server, instead of just stopping.The server would have destroyed the session by this time, and would print a warning message:
This commit fixes
escalus_bosh
to stop sending keepalives upon receiving a terminate response.Additionally, if a connection is timed out on purpose during an escalus story, one may specify it as terminated using
escalus_bosh:mark_as_terminated/1
. This will preventescalus_cleaner
from sending extraneous session termination requests to the server after the story finishes.