Skip to content

Commit

Permalink
Add encoding/hash signature to JS files
Browse files Browse the repository at this point in the history
Reviewed By: tadeuzagallo

Differential Revision: D3241028

fb-gh-sync-id: 737ae64cf3a3f4f121076dbfe933d5fe71e07817
fbshipit-source-id: 737ae64cf3a3f4f121076dbfe933d5fe71e07817
  • Loading branch information
davidaurelio authored and Facebook Github Bot 9 committed Apr 30, 2016
1 parent 8d3d8b3 commit 34dd17c
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 2 deletions.
6 changes: 4 additions & 2 deletions local-cli/bundle/output/bundle.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
'use strict';

const Promise = require('promise');
const sign = require('../sign');
const hash = require('./hash');
const writeFile = require('./writeFile');

function buildBundle(packagerClient, requestOptions) {
Expand All @@ -36,7 +36,9 @@ function saveBundleAndMap(bundle, options, log) {
log('finish');

log('Writing bundle output to:', bundleOutput);
const writeBundle = writeFile(bundleOutput, sign(codeWithMap.code), encoding);

const code = hash.appendToString(codeWithMap.code, encoding);
const writeBundle = writeFile(bundleOutput, code, encoding);
writeBundle.then(() => log('Done writing bundle output'));

if (sourcemapOutput) {
Expand Down
33 changes: 33 additions & 0 deletions local-cli/bundle/output/hash.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/**
* Copyright (c) 2015-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*/
'use strict';

const crypto = require('crypto');

const createHash = () => crypto.createHash('sha1');
const isUTF8 = encoding => /^utf-?8$/i.test(encoding);

exports.appendToString = (string, encoding) => {
const hash = createHash();
hash.update(string, encoding);
encoding = tryAsciiPromotion(string, encoding);
return string + formatSignature(encoding, hash);
};

function tryAsciiPromotion(string, encoding) {
if (!isUTF8(encoding)) { return encoding; }
for (let i = 0, n = string.length; i < n; i++) {
if (string.charCodeAt(i) > 0x7f) { return encoding; }
}
return 'ascii';
}

function formatSignature(encoding, hash) {
return `/*${encoding}:${hash.digest('hex')}*/`;
}

0 comments on commit 34dd17c

Please sign in to comment.