Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rmt): memset all config structs to zero before using #11203

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

SuGlider
Copy link
Collaborator

Description of Change

This PR makes sure that all RMT configuration data structures are set to zero before using them.
IDF 5.4 has added a new flags and it was not set to zero generating errors with trash on boot time.

Tests scenarios

ESP32 and CI using RMTLoopback.ino example.

Related links

Fixes #11200

@SuGlider SuGlider added Status: In Progress ⚠️ Issue is in progress Area: Peripherals API Relates to peripheral's APIs. bug 🐞 Inconsistencies or issues which will cause a problem for users or implementers. labels Mar 30, 2025
@SuGlider SuGlider added this to the 3.2.0 milestone Mar 30, 2025
@SuGlider SuGlider self-assigned this Mar 30, 2025
Copy link
Contributor

github-actions bot commented Mar 30, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4177e12

Copy link
Contributor

github-actions bot commented Mar 30, 2025

Test Results

 76 files   76 suites   12m 46s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 4177e12.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 30, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P40⚠️ +200.00⚠️ +0.01000.000.00
ESP32S30⚠️ +720.00⚠️ +0.02000.000.00
ESP32S20⚠️ +720.00⚠️ +0.03000.000.00
ESP32C30⚠️ +220.00⚠️ +0.01000.000.00
ESP32C60⚠️ +220.00⚠️ +0.01000.000.00
ESP32H20⚠️ +200.00⚠️ +0.01000.000.00
ESP320⚠️ +600.00⚠️ +0.02000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA00⚠️ +640⚠️ +6000000--00
AsyncUDP/examples/AsyncUDPClient0000000000--00
AsyncUDP/examples/AsyncUDPMulticastServer0000000000--00
AsyncUDP/examples/AsyncUDPServer00⚠️ +160000000--00
DNSServer/examples/CaptivePortal0000000000--00
EEPROM/examples/eeprom_class00000000000000
EEPROM/examples/eeprom_extra00000000000000
EEPROM/examples/eeprom_write00000000000000
ESP32/examples/AnalogOut/LEDCFade00000000000000
ESP32/examples/AnalogOut/LEDCSingleChannel00000000000000
ESP32/examples/AnalogOut/LEDCSoftwareFade00000000000000
ESP32/examples/AnalogOut/SigmaDelta00000000000000
ESP32/examples/AnalogOut/ledcFrequency00000000000000
ESP32/examples/AnalogOut/ledcWrite_RGB00000000000000
ESP32/examples/AnalogRead00000000000000
ESP32/examples/AnalogReadContinuous00000000000000
ESP32/examples/ArduinoStackSize00000000000000
ESP32/examples/CI/CIBoardsTest00⚠️ +600⚠️ +6000000⚠️ +6000
ESP32/examples/ChipID/GetChipID00000000000000
ESP32/examples/DeepSleep/TimerWakeUp0000000000--00
ESP32/examples/DeepSleep/TouchWakeUp000000------00
ESP32/examples/FreeRTOS/BasicMultiThreading00⚠️ +600⚠️ +6000000⚠️ +6000
ESP32/examples/FreeRTOS/Mutex00000000000000
ESP32/examples/FreeRTOS/Queue00000000000000
ESP32/examples/FreeRTOS/Semaphore00000000000000
ESP32/examples/GPIO/BlinkRGB00⚠️ +600⚠️ +6000000⚠️ +6000
ESP32/examples/GPIO/FunctionalInterrupt00000000000000
ESP32/examples/GPIO/FunctionalInterruptStruct00000000000000
ESP32/examples/GPIO/GPIOInterrupt00000000000000
ESP32/examples/HWCDC_Events00⚠️ +600--000000--
ESP32/examples/MacAddress/GetMacAddress00000000000000
ESP32/examples/RMT/Legacy_RMT_Driver_Compatible00000000000000
ESP32/examples/RMT/RMTCallback00⚠️ +640⚠️ +640⚠️ +100⚠️ +10000⚠️ +560
ESP32/examples/RMT/RMTLoopback⚠️ +200⚠️ +720⚠️ +720⚠️ +220⚠️ +220⚠️ +200⚠️ +600
ESP32/examples/RMT/RMTReadXJT00⚠️ +640⚠️ +640⚠️ +100⚠️ +10000⚠️ +560
ESP32/examples/RMT/RMTWrite_RGB_LED⚠️ +60⚠️ +600⚠️ +6000000⚠️ +60⚠️ +520
ESP32/examples/RMT/RMT_CPUFreq_Test⚠️ +60⚠️ +600⚠️ +6000000⚠️ +60⚠️ +520
ESP32/examples/RMT/RMT_EndOfTransmissionState⚠️ +60⚠️ +600⚠️ +6000000⚠️ +60⚠️ +520
ESP32/examples/RMT/RMT_LED_Blink⚠️ +60⚠️ +600⚠️ +6000000⚠️ +60⚠️ +520
ESP32/examples/ResetReason/ResetReason00000000000000
ESP32/examples/ResetReason/ResetReason200000000000000
ESP32/examples/Serial/BaudRateDetect_Demo00000000000000
ESP32/examples/Serial/OnReceiveError_BREAK_Demo00000000000000
ESP32/examples/Serial/OnReceive_Demo00000000000000
ESP32/examples/Serial/RS485_Echo_Demo00000000000000
ESP32/examples/Serial/RxFIFOFull_Demo00000000000000
ESP32/examples/Serial/RxTimeout_Demo00000000000000
ESP32/examples/Serial/Serial_All_CPU_Freqs00000000000000
ESP32/examples/Serial/Serial_STD_Func_OnReceive00000000000000
ESP32/examples/Serial/onReceiveExample00000000000000
ESP32/examples/TWAI/TWAIreceive00000000000000
ESP32/examples/TWAI/TWAItransmit00000000000000
ESP32/examples/Template/ExampleTemplate00000000000000
ESP32/examples/Time/SimpleTime0000000000--00
ESP32/examples/Timer/RepeatTimer00000000000000
ESP32/examples/Timer/WatchdogTimer00000000000000
ESP32/examples/Touch/TouchInterrupt000000------00
ESP32/examples/Touch/TouchRead000000------00
ESP32/examples/Utilities/HEXBuilder00000000000000
ESP32/examples/Utilities/MD5Builder00000000000000
ESP32/examples/Utilities/SHA1Builder00000000000000
ESP_I2S/examples/ES8388_loopback00⚠️ +600⚠️ +6000000⚠️ +6000
ESP_I2S/examples/Record_to_WAV0000--------00
ESP_I2S/examples/Simple_tone00000000000000
ESPmDNS/examples/mDNS-SD_Extended0000000000--00
ESPmDNS/examples/mDNS_Web_Server0000000000--00
Ethernet/examples/ETH_TLK11000----------00
Ethernet/examples/ETH_W5500_Arduino_SPI00⚠️ +600⚠️ +4400000⚠️ +6000
Ethernet/examples/ETH_W5500_IDF_SPI00⚠️ +600⚠️ +6400000⚠️ +6000
Ethernet/examples/ETH_WIFI_BRIDGE00⚠️ +600⚠️ +6400000--00
FFat/examples/FFat_Test00000000000000
FFat/examples/FFat_time0000000000--00
HTTPClient/examples/Authorization0000000000--00
HTTPClient/examples/BasicHttpClient0000000000--00
HTTPClient/examples/BasicHttpsClient0000000000--⚠️ +160
HTTPClient/examples/ReuseConnection0000000000--00
HTTPClient/examples/StreamHttpClient0000000000--00
HTTPUpdate/examples/httpUpdate00⚠️ +680⚠️ +6800000--00
HTTPUpdate/examples/httpUpdateSPIFFS00⚠️ +600⚠️ +6000000--00
HTTPUpdate/examples/httpUpdateSecure00⚠️ +600⚠️ +6400000--00
HTTPUpdateServer/examples/WebUpdater00⚠️ +600⚠️ +5600000--00
LittleFS/examples/LITTLEFS_test00000000000000
LittleFS/examples/LITTLEFS_time0000000000--00
NetBIOS/examples/ESP_NBNST0000000000--00
NetworkClientSecure/examples/WiFiClientInsecure0000000000--00
NetworkClientSecure/examples/WiFiClientPSK0000000000--00
NetworkClientSecure/examples/WiFiClientSecure0000000000--00
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade0000000000--00
NetworkClientSecure/examples/WiFiClientShowPeerCredentials0000000000--00
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse0000000000--00
PPP/examples/PPP_Basic00⚠️ +640⚠️ +6000000⚠️ +6000
PPP/examples/PPP_WIFI_BRIDGE00⚠️ +600⚠️ +7200000--00
Preferences/examples/Prefs2Struct00000000000000
Preferences/examples/StartCounter00000000000000
SD/examples/SD_Test00⚠️ +600⚠️ +6000000⚠️ +6000
SD/examples/SD_time00⚠️ +560⚠️ +6000000--00
SD_MMC/examples/SD2USBMSC00⚠️ +600----------
SD_MMC/examples/SDMMC_Test0000--------00
SD_MMC/examples/SDMMC_time0000--------00
SPI/examples/SPI_Multiple_Buses00⚠️ +600⚠️ +6000000⚠️ +6000
SPIFFS/examples/SPIFFS_Test00000000000000
SPIFFS/examples/SPIFFS_time0000000000--00
TFLiteMicro/examples/hello_world00000000000000
Ticker/examples/Blinker00⚠️ +600⚠️ +6000000⚠️ +6000
Ticker/examples/TickerBasic00⚠️ +600⚠️ +6000000⚠️ +6000
Ticker/examples/TickerParameter00⚠️ +600⚠️ +6000000⚠️ +6000
USB/examples/CompositeDevice00⚠️ +60000--------
USB/examples/ConsumerControl00⚠️ +60000--------
USB/examples/CustomHIDDevice00⚠️ +60000--------
USB/examples/FirmwareMSC00⚠️ +60000--------
USB/examples/Gamepad00⚠️ +60000--------
USB/examples/HIDVendor00⚠️ +60000--------
USB/examples/Keyboard/KeyboardLogout00⚠️ +60000--------
USB/examples/Keyboard/KeyboardMessage00⚠️ +60000--------
USB/examples/Keyboard/KeyboardReprogram00⚠️ +60000--------
USB/examples/Keyboard/KeyboardSerial00⚠️ +60000--------
USB/examples/KeyboardAndMouseControl00⚠️ +60000--------
USB/examples/MIDI/MidiController00⚠️ +60000--------
USB/examples/MIDI/MidiInterface00⚠️ +60000--------
USB/examples/MIDI/MidiMusicBox00⚠️ +60000--------
USB/examples/MIDI/ReceiveMidi00⚠️ +60000--------
USB/examples/Mouse/ButtonMouseControl00⚠️ +60000--------
USB/examples/SystemControl00⚠️ +60000--------
USB/examples/USBMSC00⚠️ +60000--------
USB/examples/USBSerial00⚠️ +60000--------
USB/examples/USBVendor00⚠️ +60000--------
Update/examples/AWS_S3_OTA_Update00⚠️ +600⚠️ +6000000--00
Update/examples/HTTPS_OTA_Update0000000000--00
Update/examples/HTTP_Client_AES_OTA_Update00⚠️ +600⚠️ +6800000--00
Update/examples/HTTP_Server_AES_OTA_Update00⚠️ +560⚠️ +7200000--00
Update/examples/OTAWebUpdater00⚠️ +600⚠️ +6000000--00
Update/examples/SD_Update00⚠️ +600⚠️ +6000000⚠️ +6000
WebServer/examples/AdvancedWebServer00⚠️ +600⚠️ +6400000--00
WebServer/examples/FSBrowser0000000000--00
WebServer/examples/Filters00⚠️ +600⚠️ +6000000--00
WebServer/examples/HelloServer00⚠️ +600⚠️ +6400000--00
WebServer/examples/HttpAdvancedAuth00⚠️ +600⚠️ +6400000--00
WebServer/examples/HttpAuthCallback00⚠️ +560⚠️ +6400000--00
WebServer/examples/HttpAuthCallbackInline00⚠️ +600⚠️ +6000000--00
WebServer/examples/HttpBasicAuth00⚠️ +600⚠️ +6000000--00
WebServer/examples/HttpBasicAuthSHA100⚠️ +600⚠️ +6400000--00
WebServer/examples/HttpBasicAuthSHA1orBearerToken00⚠️ +600⚠️ +6000000--00
WebServer/examples/MultiHomedServers00⚠️ +640⚠️ +6000000--00
WebServer/examples/PathArgServer0000000000--00
WebServer/examples/SDWebServer00⚠️ +560⚠️ +5600000--00
WebServer/examples/SimpleAuthentification0000000000--00
WebServer/examples/UploadHugeFile00⚠️ +640⚠️ +6800000--00
WebServer/examples/WebServer0000000000--00
WebServer/examples/WebUpdate00⚠️ +640⚠️ +4000000--00
WiFi/examples/FTM/FTM_Initiator0000000000--00
WiFi/examples/FTM/FTM_Responder0000000000--00
WiFi/examples/SimpleWiFiServer00⚠️ +640⚠️ +6000000--00
WiFi/examples/WiFiAccessPoint00⚠️ +600⚠️ +6400000--00
WiFi/examples/WiFiClient0000000000--00
WiFi/examples/WiFiClientBasic0000000000--00
WiFi/examples/WiFiClientConnect0000000000--00
WiFi/examples/WiFiClientEvents0000000000--00
WiFi/examples/WiFiClientStaticIP0000000000--00
WiFi/examples/WiFiExtender0000000000--00
WiFi/examples/WiFiIPv60000000000--00
WiFi/examples/WiFiMulti0000000000--00
WiFi/examples/WiFiMultiAdvanced0000000000--00
WiFi/examples/WiFiScan0000000000--00
WiFi/examples/WiFiScanAsync0000000000--00
WiFi/examples/WiFiScanDualAntenna0000000000--00
WiFi/examples/WiFiScanTime0000000000--00
WiFi/examples/WiFiTelnetToSerial0000000000--00
WiFi/examples/WiFiUDPClient0000000000--00
Wire/examples/WireMaster00000000000000
Wire/examples/WireScan00000000000000
Wire/examples/WireSlave00000000000000
BLE/examples/BLE5_extended_scan--00--000000--
BLE/examples/BLE5_multi_advertising--00--000000--
BLE/examples/BLE5_periodic_advertising--00--000000--
BLE/examples/BLE5_periodic_sync--00--000000--
BLE/examples/Beacon_Scanner--00--00000000
BLE/examples/Client--00--00000000
BLE/examples/EddystoneTLM_Beacon--00--00000000
BLE/examples/EddystoneURL_Beacon--00--00000000
BLE/examples/Notify--00--00000000
BLE/examples/Scan--00--00000000
BLE/examples/Server--00--00000000
BLE/examples/Server_multiconnect--00--00000000
BLE/examples/UART--00--00000000
BLE/examples/Write--00--00000000
BLE/examples/iBeacon--00--00000000
ESP32/examples/Camera/CameraWebServer (1)--0000------00
ESP32/examples/Camera/CameraWebServer (2)--0000------00
ESP32/examples/Camera/CameraWebServer (3)--00----------
ESP32/examples/DeepSleep/ExternalWakeUp--0000------00
ESP_NOW/examples/ESP_NOW_Broadcast_Master--00000000--00
ESP_NOW/examples/ESP_NOW_Broadcast_Slave--00000000--00
ESP_NOW/examples/ESP_NOW_Network--00000000--00
ESP_NOW/examples/ESP_NOW_Serial--00000000--⚠️ +160
ESP_SR/examples/Basic--⚠️ +600----------
HTTPClient/examples/HTTPClientEnterprise--00000000--00
Insights/examples/DiagnosticsSmokeTest--00000000--00
Insights/examples/MinimalDiagnostics--00000000--00
Matter/examples/MatterColorLight--⚠️ +640⚠️ +6800000--00
Matter/examples/MatterCommissionTest--00000000--00
Matter/examples/MatterComposedLights--00000000--00
Matter/examples/MatterContactSensor--⚠️ +680⚠️ +7200000--00
Matter/examples/MatterDimmableLight--⚠️ +600⚠️ +5600000--00
Matter/examples/MatterEnhancedColorLight--⚠️ +600⚠️ +6400000--00
Matter/examples/MatterFan--⚠️ +600⚠️ +6000000--00
Matter/examples/MatterHumiditySensor--00000000--00
Matter/examples/MatterMinimum--⚠️ +680⚠️ +7200000--00
Matter/examples/MatterOccupancySensor--00000000--00
Matter/examples/MatterOnIdentify--⚠️ +600⚠️ +6000000--00
Matter/examples/MatterOnOffLight--⚠️ +640⚠️ +4400000--00
Matter/examples/MatterOnOffPlugin--⚠️ +600⚠️ +4800000--00
Matter/examples/MatterPressureSensor--00000000--00
Matter/examples/MatterSmartButon--00000000--00
Matter/examples/MatterTemperatureLight--⚠️ +640⚠️ +6000000--00
Matter/examples/MatterTemperatureSensor--00000000--00
Matter/examples/MatterThermostat--00000000--00
Matter/examples/WiFiProvWithinMatter--⚠️ +480⚠️ +6800000--00
NetworkClientSecure/examples/WiFiClientSecureEnterprise--00000000--00
RainMaker/examples/RMakerCustom--⚠️ +600⚠️ +6400000----
RainMaker/examples/RMakerCustomAirCooler--⚠️ +600⚠️ +6000000----
RainMaker/examples/RMakerSonoffDualR3--⚠️ +600⚠️ +6000000----
RainMaker/examples/RMakerSwitch--⚠️ +640⚠️ +6400000----
SimpleBLE/examples/SimpleBleDevice--00--00000000
WebServer/examples/Middleware--00000000--00
WiFi/examples/WPS--00000000--00
WiFi/examples/WiFiBlueToothSwitch--00--0000--00
WiFi/examples/WiFiClientEnterprise--00000000--00
WiFi/examples/WiFiSmartConfig--00000000--00
WiFiProv/examples/WiFiProv--00000000--00
Zigbee/examples/Zigbee_Color_Dimmer_Switch--000000000000
Zigbee/examples/Zigbee_Gateway--000000----00
Zigbee/examples/Zigbee_On_Off_Switch--000000000000
Zigbee/examples/Zigbee_Range_Extender--⚠️ +680⚠️ +6000000⚠️ +6000
Zigbee/examples/Zigbee_Thermostat--000000000000
OpenThread/examples/COAP/coap_lamp--------00⚠️ +60--
OpenThread/examples/COAP/coap_switch--------00⚠️ +60--
OpenThread/examples/SimpleCLI--------0000--
OpenThread/examples/SimpleNode--------0000--
OpenThread/examples/SimpleThreadNetwork/ExtendedRouterNode--------0000--
OpenThread/examples/SimpleThreadNetwork/LeaderNode--------0000--
OpenThread/examples/SimpleThreadNetwork/RouterNode--------0000--
OpenThread/examples/ThreadScan--------0000--
OpenThread/examples/onReceive--------0000--
Zigbee/examples/Zigbee_Analog_Input_Output--------0000--
Zigbee/examples/Zigbee_CarbonDioxide_Sensor--------0000--
Zigbee/examples/Zigbee_Color_Dimmable_Light--------00⚠️ +60--
Zigbee/examples/Zigbee_Contact_Switch--------0000--
Zigbee/examples/Zigbee_Dimmable_Light--------00⚠️ +60--
Zigbee/examples/Zigbee_Illuminance_Sensor--------0000--
Zigbee/examples/Zigbee_OTA_Client--------00⚠️ +60--
Zigbee/examples/Zigbee_Occupancy_Sensor--------0000--
Zigbee/examples/Zigbee_On_Off_Light--------00⚠️ +60--
Zigbee/examples/Zigbee_Pressure_Flow_Sensor--------0000--
Zigbee/examples/Zigbee_Scan_Networks--------0000--
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy--------0000--
Zigbee/examples/Zigbee_Temperature_Sensor--------0000--
Zigbee/examples/Zigbee_Vibration_Sensor--------0000--
Zigbee/examples/Zigbee_Wind_Speed_Sensor--------0000--
Zigbee/examples/Zigbee_Window_Covering--------0000--
BluetoothSerial/examples/DiscoverConnect------------00
BluetoothSerial/examples/GetLocalMAC------------00
BluetoothSerial/examples/SerialToSerialBT------------00
BluetoothSerial/examples/SerialToSerialBTM------------00
BluetoothSerial/examples/SerialToSerialBT_Legacy------------00
BluetoothSerial/examples/SerialToSerialBT_SSP------------00
BluetoothSerial/examples/bt_classic_device_discovery------------00
BluetoothSerial/examples/bt_remove_paired_devices------------00
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code------------00
Ethernet/examples/ETH_LAN8720------------00

@SuGlider SuGlider added Status: Review needed Issue or PR is awaiting review and removed Status: In Progress ⚠️ Issue is in progress labels Mar 31, 2025
@SuGlider SuGlider modified the milestones: 3.2.0, 3.2.1 Mar 31, 2025
@SuGlider SuGlider added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Apr 1, 2025
@SuGlider SuGlider merged commit 22f07d0 into master Apr 1, 2025
57 checks passed
@SuGlider SuGlider deleted the rmt_config_memset branch April 1, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Peripherals API Relates to peripheral's APIs. bug 🐞 Inconsistencies or issues which will cause a problem for users or implementers. Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

RMT: RMTLoopback example hangs and gives core error
3 participants