Better support for errored cells

estudiogcg · Jun 3, 2018 · f7c483a · f7c483a
1 parent 1b64a06
commit f7c483a
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/src/Spout/Common/Entity/Cell.php b/src/Spout/Common/Entity/Cell.php
@@ -88,7 +88,7 @@ public function setValue($value)
      */
     public function getValue()
     {
-        return $this->value;
+        return !$this->isError() ? $this->value : null;
     }
 
     /**
@@ -203,6 +203,6 @@ public function isError()
      */
     public function __toString()
     {
-        return (string) $this->value;
+        return (string) $this->getValue();
     }
 }
diff --git a/src/Spout/Common/Entity/Row.php b/src/Spout/Common/Entity/Row.php
@@ -117,7 +117,7 @@ public function setStyle($style)
     public function toArray()
     {
         return array_map(function (Cell $cell) {
-            return !$cell->isError() ? $cell->getValue() : null;
+            return $cell->getValue();
         }, $this->cells);
     }
 }
diff --git a/tests/Spout/Common/Entity/CellTest.php b/tests/Spout/Common/Entity/CellTest.php
@@ -2,7 +2,9 @@
 
 namespace Box\Spout\Common\Entity;
 
-class CellTest extends \PHPUnit\Framework\TestCase
+use PHPUnit\Framework\TestCase;
+
+class CellTest extends TestCase
 {
     /**
      * @return void
@@ -70,4 +72,14 @@ public function testCellTypeError()
     {
         $this->assertTrue((new Cell([]))->isError());
     }
+
+    /**
+     * @return void
+     */
+    public function testErroredCellValueShouldBeNull()
+    {
+        $cell = new Cell([]);
+        $this->assertTrue($cell->isError());
+        $this->assertNull($cell->getValue());
+    }
 }