Skip to content

Commit

Permalink
Remove problematic test
Browse files Browse the repository at this point in the history
  • Loading branch information
francois141 authored and cvetkovic committed Apr 23, 2024
1 parent 6d1ffbd commit f9771b4
Showing 1 changed file with 0 additions and 159 deletions.
159 changes: 0 additions & 159 deletions internal/control_plane/control_plane_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1227,165 +1227,6 @@ func TestEndpointsWithDeregistration(t *testing.T) {
assert.Zero(t, sum)
}

func TestEndpointsWithDeregistrationMultipleNodes(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()

logrus.SetLevel(logrus.FatalLevel)

size := 2

persistenceLayer := mock_persistence.NewMockPersistenceLayer(ctrl)

persistenceLayer.EXPECT().StoreServiceInformation(gomock.Any(), gomock.Any()).DoAndReturn(func(_ context.Context, _ *proto.ServiceInfo) error {
return nil
}).Times(size)

persistenceLayer.EXPECT().StoreWorkerNodeInformation(gomock.Any(), gomock.Any()).DoAndReturn(func(ctx context.Context, workerNodeInfo *proto.WorkerNodeInformation) error {
return nil
}).Times(2)

persistenceLayer.EXPECT().DeleteWorkerNodeInformation(gomock.Any(), gomock.Any()).DoAndReturn(func(_ context.Context, _ string) error {
return nil
}).Times(2)

persistenceLayer.EXPECT().SetLeader(gomock.Any()).DoAndReturn(func(_ context.Context) error {
return nil
}).AnyTimes()

controlPlane := NewControlPlane(persistenceLayer, "", placement_policy.NewRandomPlacement(), empty_dataplane.NewDataplaneConnectionEmpty, empty_worker.NewEmptyWorkerNode, &mockConfig)

status, err := controlPlane.RegisterNode(context.Background(), &proto.NodeInfo{
NodeID: "mockNode",
IP: uuid.New().String(),
Port: 0,
CpuCores: 0,
MemorySize: 0,
})

assert.NotNil(t, status)
assert.NoError(t, err)

status, err = controlPlane.RegisterNode(context.Background(), &proto.NodeInfo{
NodeID: "mockNode2",
IP: uuid.New().String(),
Port: 0,
CpuCores: 0,
MemorySize: 0,
})

assert.True(t, status.Success)
assert.NoError(t, err)

for i := 0; i < size; i++ {
autoscalingConfig := autoscaling.NewDefaultAutoscalingMetadata()
autoscalingConfig.ScalingUpperBound = 1
//autoscalingConfig.ScalingLowerBound = 1

status, err = controlPlane.RegisterService(context.Background(), &proto.ServiceInfo{
Name: "mock" + fmt.Sprint(i),
Image: "",
PortForwarding: nil,
AutoscalingConfig: autoscalingConfig,
})

assert.True(t, status.Success, "status should be successful")
assert.NoError(t, err, "error should not be nil")
}

for i := 0; i < size; i++ {
status, err = controlPlane.OnMetricsReceive(context.Background(), &proto.AutoscalingMetric{
ServiceName: "mock" + fmt.Sprint(i),
DataplaneName: "",
InflightRequests: 1,
})

assert.True(t, status.Success)
assert.NoError(t, err)
}

time.Sleep(time.Second)

status, err = controlPlane.DeregisterNode(context.Background(), &proto.NodeInfo{
NodeID: "mockNode",
IP: uuid.New().String(),
Port: 0,
CpuCores: 0,
MemorySize: 0,
})

assert.True(t, status.Success)
assert.NoError(t, err)

time.Sleep(time.Second)

controlPlane.NIStorage.Lock()
controlPlane.SIStorage.Lock()

// Assert structures are consistent
sum := 0
for _, value := range controlPlane.SIStorage.GetMap() {
sum += len(value.Controller.Endpoints)
}
for _, value := range controlPlane.NIStorage.GetMap() {
sum -= value.GetEndpointMap().Len()
}

controlPlane.NIStorage.Unlock()
controlPlane.SIStorage.Unlock()

assert.Zero(t, sum)

time.Sleep(time.Second)

// Make sure scaling loop reconstructs as expected
sum = 0
for _, value := range controlPlane.SIStorage.GetMap() {
sum += len(value.Controller.Endpoints)
}

assert.Equal(t, size, sum)

sum = 0
for _, value := range controlPlane.NIStorage.GetMap() {
sum += value.GetEndpointMap().Len()
}

assert.Equal(t, size, sum)

status, err = controlPlane.DeregisterNode(context.Background(), &proto.NodeInfo{
NodeID: "mockNode2",
IP: uuid.New().String(),
Port: 0,
CpuCores: 0,
MemorySize: 0,
})

assert.True(t, status.Success)
assert.NoError(t, err)

time.Sleep(time.Second)

controlPlane.NIStorage.Lock()
controlPlane.SIStorage.Lock()

// Assert structures are consistent
sum = 0
for _, value := range controlPlane.SIStorage.GetMap() {
sum += len(value.Controller.Endpoints)
}
assert.Zero(t, sum)

sum = 0
for _, value := range controlPlane.NIStorage.GetMap() {
sum -= value.GetEndpointMap().Len()
}
assert.Zero(t, sum)

controlPlane.NIStorage.Unlock()
controlPlane.SIStorage.Unlock()
}

// Other tests

func TestEndpointSearchByContainerName(t *testing.T) {
Expand Down

0 comments on commit f9771b4

Please sign in to comment.