Correct build issues related to issue ARM-software#197

Problem with f16 Implicit conversions from float to int
ethanbanez · Jul 16, 2024 · fc6da81 · fc6da81
1 parent 60a6ec1
commit fc6da81
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 10 deletions.
diff --git a/Source/DistanceFunctions/arm_dtw_path_f32.c b/Source/DistanceFunctions/arm_dtw_path_f32.c
@@ -141,18 +141,19 @@ ARM_DSP_ATTRIBUTE void arm_dtw_path_f32(const arm_matrix_instance_f32 *pDTW,
 
   /* Reverse the path */
   int16_t *fh,*sh;
+  int16_t itemp;
   fh = pPath;
   sh = pPath + 2* (*pathLength)-2;
   int halfLength = (*pathLength)>>1;
   for(int i = 0; i< halfLength; i++)
   {
-     temp = fh[0];
+     itemp = fh[0];
      fh[0] = sh[0];
-     sh[0] = temp;
+     sh[0] = itemp;
 
-     temp = fh[1];
+     itemp = fh[1];
      fh[1] = sh[1];
-     sh[1] = temp;
+     sh[1] = itemp;
 
      fh += 2;
      sh -= 2;

diff --git a/Source/FastMathFunctions/arm_atan2_f16.c b/Source/FastMathFunctions/arm_atan2_f16.c
@@ -135,7 +135,7 @@ ARM_DSP_ATTRIBUTE arm_status arm_atan2_f16(float16_t y,float16_t x,float16_t *re
         }
         else
         {
-            if (signbit(y))
+            if (signbit((float)y))
             {
                *result= -(_Float16)PIF16;
             }

diff --git a/Source/TransformFunctions/arm_bitreversal_f16.c b/Source/TransformFunctions/arm_bitreversal_f16.c
@@ -28,11 +28,7 @@
 
 #include "dsp/transform_functions_f16.h"
 
-void arm_bitreversal_f16(
-float16_t * pSrc,
-uint16_t fftSize,
-uint16_t bitRevFactor,
-const uint16_t * pBitRevTab);
+
 
 /*
 * @brief  In-place bit reversal function.
@@ -44,6 +40,12 @@ const uint16_t * pBitRevTab);
 
 #if defined(ARM_FLOAT16_SUPPORTED)
 
+void arm_bitreversal_f16(
+float16_t * pSrc,
+uint16_t fftSize,
+uint16_t bitRevFactor,
+const uint16_t * pBitRevTab);
+
 ARM_DSP_ATTRIBUTE void arm_bitreversal_f16(
 float16_t * pSrc,
 uint16_t fftSize,

diff --git a/Testing/cmsis_build/cdefault.yml b/Testing/cmsis_build/cdefault.yml
@@ -7,6 +7,7 @@ default:
       C:
         - -Wsign-compare 
         - -Wdouble-promotion 
+        - -Wfloat-conversion 
         - -DNDEBUG 
         - -Wall 
         - -Wextra  
@@ -55,6 +56,7 @@ default:
       C:
         - -Wsign-compare 
         - -Wdouble-promotion 
+        - -Wfloat-conversion 
         - -DNDEBUG 
         - -Wall 
         - -Wextra  
@@ -102,6 +104,7 @@ default:
       C:
          - -Wsign-compare 
          - -Wdouble-promotion 
+         - -Wfloat-conversion 
          - -DNDEBUG 
          - -Wall 
          - -Wextra  

diff --git a/dsppp/cdefault.yml b/dsppp/cdefault.yml
@@ -7,6 +7,7 @@ default:
       C:
         - -Wsign-compare 
         - -Wdouble-promotion 
+        - -Wfloat-conversion 
         - -DNDEBUG 
         - -Wall 
         - -Wextra  
@@ -30,6 +31,8 @@ default:
       CPP:
         - -fno-rtti 
         - -fno-exceptions
+        - -Wdouble-promotion 
+        - -Wfloat-conversion 
         - -DNDEBUG 
         - -Wall 
         - -Wextra  
@@ -53,6 +56,7 @@ default:
       C:
         - -Wsign-compare 
         - -Wdouble-promotion 
+        - -Wfloat-conversion 
         - -DNDEBUG 
         - -Wall 
         - -Wextra 
@@ -73,6 +77,8 @@ default:
       CPP:
         - -fno-rtti 
         - -fno-exceptions
+        - -Wdouble-promotion 
+        - -Wfloat-conversion 
         - -DNDEBUG 
         - -Wall 
         - -Wextra  
@@ -100,6 +106,7 @@ default:
       C:
          - -Wsign-compare 
          - -Wdouble-promotion 
+         - -Wfloat-conversion 
          - -DNDEBUG 
          - -Wall 
          - -Wextra  
@@ -122,6 +129,8 @@ default:
       CPP:
         - -fno-rtti 
         - -fno-exceptions
+        - -Wdouble-promotion 
+        - -Wfloat-conversion 
         - -DNDEBUG 
         - -Wall 
         - -Wextra
-Original file line number
+Diff line change
@@ Expand Up @@
             }
             else
             {
-                if (signbit(y))
+                if (signbit((float)y))
                 {
                    *result= -(_Float16)PIF16;
                 }
@@ Expand Down @@