Move loose semantic and syntax tests to subdirs #15765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
move-loose-tests-to-subdirs
branch
from
6e567f4 to
4bf53f1
Compare
clonker
approved these changes
Jan 24, 2025
cameel
force-pushed
the
move-loose-tests-to-subdirs
branch
from
4bf53f1 to
ea905bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15665 we're placing EOF-specific tests into
eof/subdir. This creates a weird ambiguity with files that are not in subdirs, because it adds a top-leveleof/, which looks like a catch-all place for EOF-related tests. This will create a mess so I decided to prevent this.Most of these loose files fit into existing directories anyway and I noticed that having them at the top level just encourages people to add more if they're not sure where to drop a test (rather than just create a new dir).