Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some exported compiler flags #36

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

HannesSommer
Copy link
Contributor

Before, this package was exporting "-Wall -Wextra -Wno-unused-parameter" to all its (in)direct dependers.

Does somebody remember why this was done in the first place?

Before, this package was exporting "-Wall -Wextra -Wno-unused-parameter" to all its (in)direct dependers.
@HannesSommer
Copy link
Contributor Author

@schneith, you are using this, don't you? Any objections, against merging?

@schneith
Copy link

schneith commented Feb 6, 2017

@HannesSommer
that looks good to me. forcing these settings for other projects seems wrong.

@schneith schneith requested review from schneith and removed request for schneith February 6, 2017 11:48
@HannesSommer
Copy link
Contributor Author

Thanks.

@HannesSommer HannesSommer merged commit 22a6247 into master Feb 6, 2017
@HannesSommer HannesSommer deleted the fix/removedSomeExporedCompilerFlags branch February 6, 2017 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants