Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConfigSampler to handle trials without hash #616

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Conversation

d-a-bunin
Copy link
Collaborator

@d-a-bunin d-a-bunin commented Feb 17, 2025

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  • Add .user_attrs.get("hash") in ConfigSampler._get_unfinished_hashes
  • Add additional check on if len(unfinished_hash) == 0 copied from GridSampler

Closing issues

Closes #607

@d-a-bunin d-a-bunin self-assigned this Feb 17, 2025
Copy link

github-actions bot commented Feb 17, 2025

🚀 Deployed on https://deploy-preview-616--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 17, 2025 13:27 Inactive
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.47%. Comparing base (797cfe3) to head (fac9dbd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
etna/auto/optuna/config_sampler.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   90.42%   90.47%   +0.05%     
==========================================
  Files         259      259              
  Lines       18036    18041       +5     
==========================================
+ Hits        16309    16323      +14     
+ Misses       1727     1718       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-a-bunin d-a-bunin requested a review from brsnw250 February 18, 2025 07:46
@github-actions github-actions bot temporarily deployed to pull request February 20, 2025 07:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 20, 2025 09:02 Inactive
@d-a-bunin d-a-bunin merged commit 760a6e9 into master Feb 20, 2025
14 checks passed
@d-a-bunin d-a-bunin deleted the issue-607 branch February 20, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error on using ConfigSampler with joblib.Parallel
2 participants