forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Pulsar Function localrun with multiple instances and metrics serv…
…er is enabled (apache#10208)
- Loading branch information
Showing
16 changed files
with
473 additions
and
195 deletions.
There are no files selected for viewing
255 changes: 177 additions & 78 deletions
255
...r-broker/src/test/java/org/apache/pulsar/functions/worker/PulsarFunctionLocalRunTest.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
...e/src/main/java/org/apache/pulsar/functions/instance/stats/FunctionCollectorRegistry.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.pulsar.functions.instance.stats; | ||
|
|
||
| import io.prometheus.client.Collector; | ||
| import io.prometheus.client.CollectorRegistry; | ||
|
|
||
| /** | ||
| * Internal representation of Prometheus Collector Registry | ||
| */ | ||
| public abstract class FunctionCollectorRegistry extends CollectorRegistry { | ||
| public static FunctionCollectorRegistry getDefaultImplementation() { | ||
| return new FunctionCollectorRegistryImpl(); | ||
| } | ||
|
|
||
| /** | ||
| * Register a metric if it does not yet exist. If it does exist, then return the existing metric. | ||
| * Currently, only needed by the LocalRunner when running in threaded and exposing metrics via a http server. | ||
| * This method helps resolve the conflict in which multiple instances within the LocalRunner process try to register the same metric. | ||
| * @param metricName the name of the metric | ||
| * @param collector the metric object e.g. Count, Gauge, etc. | ||
| * @param <T> | ||
| * @return If the metric with the name `metricName` already exists, return the existing metric object. If not, return null | ||
| */ | ||
| public abstract <T extends Collector> T registerIfNotExist(String metricName, T collector); | ||
| } |
42 changes: 42 additions & 0 deletions
42
...c/main/java/org/apache/pulsar/functions/instance/stats/FunctionCollectorRegistryImpl.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.pulsar.functions.instance.stats; | ||
|
|
||
| import io.prometheus.client.Collector; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| public class FunctionCollectorRegistryImpl extends FunctionCollectorRegistry { | ||
|
|
||
| private final Map<String, Collector> namesToCollectors = new HashMap<String, Collector>(); | ||
|
|
||
| public Collector registerIfNotExist(String metricName, Collector collector) { | ||
| synchronized (this) { | ||
| Collector existingCollector = namesToCollectors.get(metricName); | ||
| if (existingCollector == null) { | ||
| namesToCollectors.put(metricName, collector); | ||
| super.register(collector); | ||
| return collector; | ||
| } | ||
| return existingCollector; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.