[improve][broker] Use bulk operation instead of iteration (apache#20219)

eugene-cheverda · May 6, 2023 · 9cb0503 · 9cb0503
1 parent 9f7a539
commit 9cb0503
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
@@ -226,7 +226,7 @@ protected CompletableFuture<Map<String, Set<AuthAction>>> internalGetPermissions
                 String topicUri = topicName.toString();
                 AuthPolicies auth = policies.get().auth_policies;
                 // First add namespace level permissions
-                auth.getNamespaceAuthentication().forEach(permissions::put);
+                permissions.putAll(auth.getNamespaceAuthentication());
 
                 // Then add topic level permissions
                 if (auth.getTopicAuthentication().containsKey(topicUri)) {

diff --git a/...ker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java b/...ker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
@@ -68,9 +68,7 @@ private void loadAllResourceGroups() {
             final Set<String> existingSet = rgService.resourceGroupGetAll();
             HashSet<String> newSet = new HashSet<>();
 
-            for (String rgName : rgList) {
-                newSet.add(rgName);
-            }
+            newSet.addAll(rgList);
 
             final Sets.SetView<String> deleteList = Sets.difference(existingSet, newSet);
 

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
@@ -204,11 +204,10 @@ public synchronized void updateStats(
                 }
             });
             if (clusterReplicationMetrics.isMetricsEnabled()) {
-                clusterReplicationMetrics.get().forEach(clusterMetric -> tempMetricsCollection.add(clusterMetric));
+                tempMetricsCollection.addAll(clusterReplicationMetrics.get());
                 clusterReplicationMetrics.reset();
             }
-            brokerOperabilityMetrics.getMetrics()
-                    .forEach(brokerOperabilityMetric -> tempMetricsCollection.add(brokerOperabilityMetric));
+            tempMetricsCollection.addAll(brokerOperabilityMetrics.getMetrics());
 
             // json end
             topicStatsStream.endObject();