fix logger number not correct in tests (apache#12168)

### Motivation Log placehodlers not correct. Cause some log info is missing or `{}` alone ### Modifications Fix the placeholder, add `{}` or delete `{}`
eugene-cheverda · Sep 26, 2021 · a69611c · a69611c
1 parent 1e133e9
commit a69611c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/...e/bcfips-include-test/src/test/java/org/apache/pulsar/client/TlsProducerConsumerTest.java b/...e/bcfips-include-test/src/test/java/org/apache/pulsar/client/TlsProducerConsumerTest.java
@@ -43,7 +43,7 @@ public void testTlsLargeSizeMessage() throws Exception {
         log.info("-- Starting {} test --", methodName);
 
         final int MESSAGE_SIZE = 16 * 1024 + 1;
-        log.info("-- message size --", MESSAGE_SIZE);
+        log.info("-- message size {} --", MESSAGE_SIZE);
 
         internalSetUpForClient(true, pulsar.getBrokerServiceUrlTls());
         internalSetUpForNamespace();
@@ -77,7 +77,7 @@ public void testTlsClientAuthOverBinaryProtocol() throws Exception {
         log.info("-- Starting {} test --", methodName);
 
         final int MESSAGE_SIZE = 16 * 1024 + 1;
-        log.info("-- message size --", MESSAGE_SIZE);
+        log.info("-- message size {} --", MESSAGE_SIZE);
         internalSetUpForNamespace();
 
         // Test 1 - Using TLS on binary protocol without sending certs - expect failure
@@ -88,7 +88,7 @@ public void testTlsClientAuthOverBinaryProtocol() throws Exception {
             Assert.fail("Server should have failed the TLS handshake since client didn't .");
         } catch (Exception ex) {
             // OK
-            log.info("first test success: without certs set, meet exception {}", ex);
+            log.info("first test success: without certs set, meet exception ", ex);
         }
 
         // Test 2 - Using TLS on binary protocol - sending certs
@@ -107,7 +107,7 @@ public void testTlsClientAuthOverHTTPProtocol() throws Exception {
         log.info("-- Starting {} test --", methodName);
 
         final int MESSAGE_SIZE = 16 * 1024 + 1;
-        log.info("-- message size --", MESSAGE_SIZE);
+        log.info("-- message size {} --", MESSAGE_SIZE);
         internalSetUpForNamespace();
 
         // Test 1 - Using TLS on https without sending certs - expect failure
@@ -118,7 +118,7 @@ public void testTlsClientAuthOverHTTPProtocol() throws Exception {
             Assert.fail("Server should have failed the TLS handshake since client didn't .");
         } catch (Exception ex) {
             // OK
-            log.info("first test success: without certs set, meet exception {}", ex);
+            log.info("first test success: without certs set, meet exception ", ex);
         }
 
         // Test 2 - Using TLS on https - sending certs

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
@@ -924,7 +924,7 @@ public void validatePoliciesReadOnlyAccess() {
                 throw new RestException(Status.FORBIDDEN, "Broker is forbidden to do read-write operations");
             }
         } catch (Exception e) {
-            log.warn("Unable to fetch read-only policy config {}", e);
+            log.warn("Unable to fetch read-only policy config ", e);
             throw new RestException(e);
         }
     }

diff --git a/...tic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClientTests.java b/...tic-search/src/test/java/org/apache/pulsar/io/elasticsearch/ElasticSearchClientTests.java
@@ -257,7 +257,7 @@ public void testBulkBlocking() throws Exception {
             long start = System.currentTimeMillis();
             for (int i = 6; i <= 15; i++) {
                 client.bulkIndex(mockRecord, Pair.of(Integer.toString(i), "{\"a\":" + i + "}"));
-                log.info("{} index [}", System.currentTimeMillis(), i);
+                log.info("{} index {}", System.currentTimeMillis(), i);
             }
             long elapsed = System.currentTimeMillis() - start;
             log.info("elapsed = {}", elapsed);

diff --git a/...tegration/src/test/java/org/apache/pulsar/tests/integration/topologies/PulsarCluster.java b/...tegration/src/test/java/org/apache/pulsar/tests/integration/topologies/PulsarCluster.java
@@ -662,7 +662,7 @@ public void dumpFunctionLogs(String name) {
                 });
                 log.info("Function {} logs {}", name, logs);
             } catch (com.github.dockerjava.api.exception.NotFoundException notFound) {
-                log.info("Cannot download {} logs from {}", name, container.getContainerName(), notFound.toString());
+                log.info("Cannot download {} logs from {} not found exception {}", name, container.getContainerName(), notFound.toString());
             } catch (Throwable err) {
                 log.info("Cannot download {} logs from {}", name, container.getContainerName(), err);
             }