forked from square/retrofit
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce checkstyle to enforce code style. Clean-up files to pass.
- Loading branch information
1 parent
44e7c9c
commit 704f59d
Showing
19 changed files
with
257 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,7 +50,7 @@ | |
* @author Bob Lee ([email protected]) | ||
*/ | ||
public class QueueFile { | ||
private static final Logger logger = | ||
private static final Logger LOGGER = | ||
Logger.getLogger(QueueFile.class.getName()); | ||
|
||
/** Initial file size in bytes. */ | ||
|
@@ -501,7 +501,8 @@ public synchronized void remove() throws IOException { | |
public synchronized void clear() throws IOException { | ||
writeHeader(INITIAL_LENGTH, 0, 0, 0); | ||
elementCount = 0; | ||
first = last = Element.NULL; | ||
first = Element.NULL; | ||
last = Element.NULL; | ||
fileLength = INITIAL_LENGTH; | ||
if (fileLength > INITIAL_LENGTH) setLength(INITIAL_LENGTH); | ||
} | ||
|
@@ -533,7 +534,7 @@ public synchronized void close() throws IOException { | |
} | ||
}); | ||
} catch (IOException e) { | ||
logger.log(Level.WARNING, "read error", e); | ||
LOGGER.log(Level.WARNING, "read error", e); | ||
} | ||
builder.append("]]"); | ||
return builder.toString(); | ||
|
@@ -590,6 +591,6 @@ public interface ElementReader { | |
* which case it reads all the remaining bytes. Not buffered. | ||
* @param length of element data in bytes | ||
*/ | ||
public void read(InputStream in, int length) throws IOException; | ||
void read(InputStream in, int length) throws IOException; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
<?xml version="1.0"?> | ||
<!DOCTYPE module PUBLIC | ||
"-//Puppy Crawl//DTD Check Configuration 1.2//EN" | ||
"http://www.puppycrawl.com/dtds/configuration_1_2.dtd"> | ||
|
||
<module name="Checker"> | ||
<!--module name="NewlineAtEndOfFile"/--> | ||
<module name="FileLength"/> | ||
<module name="FileTabCharacter"/> | ||
|
||
<!-- Trailing spaces --> | ||
<module name="RegexpSingleline"> | ||
<property name="format" value="\s+$"/> | ||
<property name="message" value="Line has trailing spaces."/> | ||
</module> | ||
|
||
<module name="TreeWalker"> | ||
<property name="cacheFile" value="${checkstyle.cache.file}"/> | ||
|
||
<!-- Checks for Javadoc comments. --> | ||
<!-- See http://checkstyle.sf.net/config_javadoc.html --> | ||
<!--module name="JavadocMethod"/--> | ||
<!--module name="JavadocType"/--> | ||
<!--module name="JavadocVariable"/--> | ||
<!--module name="JavadocStyle"/--> | ||
|
||
|
||
<!-- Checks for Naming Conventions. --> | ||
<!-- See http://checkstyle.sf.net/config_naming.html --> | ||
<module name="ConstantName"/> | ||
<module name="LocalFinalVariableName"/> | ||
<module name="LocalVariableName"/> | ||
<module name="MemberName"/> | ||
<module name="MethodName"/> | ||
<module name="PackageName"/> | ||
<module name="ParameterName"/> | ||
<module name="StaticVariableName"/> | ||
<module name="TypeName"/> | ||
|
||
|
||
<!-- Checks for imports --> | ||
<!-- See http://checkstyle.sf.net/config_import.html --> | ||
<module name="AvoidStarImport"/> | ||
<module name="IllegalImport"/> <!-- defaults to sun.* packages --> | ||
<module name="RedundantImport"/> | ||
<module name="UnusedImports"/> | ||
|
||
|
||
<!-- Checks for Size Violations. --> | ||
<!-- See http://checkstyle.sf.net/config_sizes.html --> | ||
<module name="LineLength"> | ||
<property name="max" value="120"/> | ||
</module> | ||
<!--module name="MethodLength"/--> | ||
<!--module name="ParameterNumber"/--> | ||
|
||
|
||
<!-- Checks for whitespace --> | ||
<!-- See http://checkstyle.sf.net/config_whitespace.html --> | ||
<module name="GenericWhitespace"/> | ||
<module name="EmptyForIteratorPad"/> | ||
<module name="MethodParamPad"/> | ||
<module name="NoWhitespaceAfter"/> | ||
<module name="NoWhitespaceBefore"/> | ||
<module name="OperatorWrap"/> | ||
<module name="ParenPad"/> | ||
<!--module name="TypecastParenPad"/--> | ||
<module name="WhitespaceAfter"/> | ||
<module name="WhitespaceAround"/> | ||
|
||
|
||
<!-- Modifier Checks --> | ||
<!-- See http://checkstyle.sf.net/config_modifiers.html --> | ||
<!--module name="ModifierOrder"/--> | ||
<module name="RedundantModifier"/> | ||
|
||
|
||
<!-- Checks for blocks. You know, those {}'s --> | ||
<!-- See http://checkstyle.sf.net/config_blocks.html --> | ||
<!--module name="AvoidNestedBlocks"/--> | ||
<!--module name="EmptyBlock"/--> | ||
<module name="LeftCurly"/> | ||
<!--module name="NeedBraces"/--> | ||
<module name="RightCurly"/> | ||
|
||
|
||
<!-- Checks for common coding problems --> | ||
<!-- See http://checkstyle.sf.net/config_coding.html --> | ||
<!--module name="AvoidInlineConditionals"/--> | ||
<module name="CovariantEquals"/> | ||
<module name="DoubleCheckedLocking"/> | ||
<module name="EmptyStatement"/> | ||
<module name="EqualsAvoidNull"/> | ||
<module name="EqualsHashCode"/> | ||
<!--module name="HiddenField"/--> | ||
<module name="IllegalInstantiation"/> | ||
<module name="InnerAssignment"/> | ||
<!--module name="MagicNumber"/--> | ||
<module name="MissingSwitchDefault"/> | ||
<module name="RedundantThrows"/> | ||
<module name="SimplifyBooleanExpression"/> | ||
<module name="SimplifyBooleanReturn"/> | ||
|
||
<!-- Checks for class design --> | ||
<!-- See http://checkstyle.sf.net/config_design.html --> | ||
<!--module name="DesignForExtension"/--> | ||
<!--module name="FinalClass"/--> | ||
<!--module name="HideUtilityClassConstructor"/--> | ||
<!--module name="InterfaceIsType"/--> | ||
<!--module name="VisibilityModifier"/--> | ||
|
||
|
||
<!-- Miscellaneous other checks. --> | ||
<!-- See http://checkstyle.sf.net/config_misc.html --> | ||
<!--module name="ArrayTypeStyle"/--> | ||
<!--module name="FinalParameters"/--> | ||
<!--module name="TodoComment"/--> | ||
<module name="UpperEll"/> | ||
</module> | ||
</module> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ | |
* @author Bob Lee ([email protected]) | ||
*/ | ||
public class Fetcher { | ||
private static final Logger logger = | ||
private static final Logger LOGGER = | ||
Logger.getLogger(Fetcher.class.getName()); | ||
|
||
// TODO: Support conditional get. | ||
|
@@ -62,7 +62,7 @@ public void run() { | |
httpClientProvider.get().execute(get, new DownloadHandler(gson, destination, | ||
uiCallback, progressListener, mainThread)); | ||
} catch (IOException e) { | ||
logger.log(Level.WARNING, "fetch exception", e); | ||
LOGGER.log(Level.WARNING, "fetch exception", e); | ||
uiCallback.networkError(); | ||
} catch (Throwable t) { | ||
uiCallback.unexpectedError(t); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.