Skip to content

Commit

Permalink
Fix helm lint error for zookeeper-metadata.yaml (apache#2878)
Browse files Browse the repository at this point in the history
### Motivation

The following errors occurs when running : 

helm lint pulsar/
==> Linting pulsar/
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/: render error in "pulsar/templates/zookeeper-metadata.yaml": template: pulsar/templates/zookeeper-metadata.yaml:49:20: executing "pulsar/templates/zookeeper-metadata.yaml" at <.Values.zookeeper_me...>: can't evaluate field resources in type interface {}

### Modifications

Change  zookeeper_metadata in deployment/kubernetes/helm/pulsar/templates/zookeeper-metadata.yaml to zookeeperMetadata

### Result

helm lint pulsar/
==> Linting pulsar/
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, no failures
  • Loading branch information
benjaminhuo authored and sijie committed Oct 29, 2018
1 parent f7a91a1 commit aad7300
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ spec:
- name: "{{ template "pulsar.fullname" . }}-{{ .Values.zookeeperMetadata.component }}"
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- if .Values.zookeeper_metadata.resources }}
{{- if .Values.zookeeperMetadata.resources }}
resources:
{{ toYaml .Values.zookeeper_metadata.resources | indent 10 }}
{{ toYaml .Values.zookeeperMetadata.resources | indent 10 }}
{{- end }}
command: ["sh", "-c"]
args:
Expand Down
1 change: 1 addition & 0 deletions deployment/kubernetes/helm/pulsar/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ proxy:
##
service:
annotations: {}
type: NodePort
ports:
- name: http
port: 8080
Expand Down

0 comments on commit aad7300

Please sign in to comment.