fix vr-object tests, getting baseline tests back up and running (afra…

…mevr#195)

package.json

@@ -20,10 +20,10 @@
     "garnish": "^3.2.0",
     "gh-pages": "^0.4.0",
     "husky": "^0.10.1",
-    "karma": "^0.13.9",
-    "karma-browserify": "4.3.0",
+    "karma": "^0.13.15",
+    "karma-browserify": "^4.4.0",
     "karma-chai-shallow-deep-equal": "0.0.4",
-    "karma-firefox-launcher": "^0.1.4",
+    "karma-firefox-launcher": "^0.1.6",
     "karma-mocha": "^0.2.0",
     "karma-mocha-reporter": "^1.1.0",
     "karma-sinon-chai": "^1.1.0",
@@ -46,8 +46,8 @@
     "ghpages": "node ./scripts/gh-pages",
     "gh-pages": "npm run ghpages",
     "release": "npm login && npm version patch --minor && npm publish",
-    "test": "karma start ./test/karma.conf.js",
-    "test:ci": "karma start ./test/karma.conf.js --single-run",
+    "test": "karma start ./tests/karma.conf.js",
+    "test:ci": "karma start ./tests/karma.conf.js --single-run",
     "lint": "semistandard -v $(git ls-files '*.js') | snazzy",
     "precommit": "npm run lint"
   },

src/components/rotation.js

@@ -1,7 +1,7 @@
 var coordinateParser = require('./coordinate-parser');
 var registerComponent = require('../core/register-component').registerComponent;
-var THREE = require('../../lib/three');
 var utils = require('../vr-utils');
+var THREE = require('../../lib/three');
 
 var proto = {
   defaults: {
@@ -12,16 +12,17 @@ var proto = {
     }
   },
 
+  /**
+   * Updates object3D rotation.
+   */
   update: {
     value: function () {
       var data = this.data;
       var object3D = this.el.object3D;
-      // Updates three.js object
-      var rotationX = THREE.Math.degToRad(data.x);
-      var rotationY = THREE.Math.degToRad(data.y);
-      var rotationZ = THREE.Math.degToRad(data.z);
-      // Updates three.js object
-      object3D.rotation.set(rotationX, rotationY, rotationZ);
+      object3D.rotation.set(THREE.Math.degToRad(data.x),
+                            THREE.Math.degToRad(data.y),
+                            THREE.Math.degToRad(data.z));
+      object3D.rotation.order = 'YXZ';
     }
   }
 };

src/core/component.js

@@ -121,6 +121,11 @@ Component.prototype = {
     return utils.mixin({}, data);
   },
 
+  /**
+   * Calls style parser on a component string.
+   *
+   * @returns {object}
+   */
   parseAttributesString: function (attrs) {
     if (typeof attrs !== 'string') { return attrs; }
     // We camel case keys so for instance max-value is equivalent to maxValue

src/core/vr-object.js

@@ -287,6 +287,14 @@ var proto = {
     writable: window.debug
   },
 
+  /**
+   * If attribute is a component, it parses the style-like string into an
+   * object. Returned component data does not include applied mixins or
+   * defaults.
+   *
+   * @param {string} attr
+   * @returns {object|string} Object if component, else string.
+   */
   getAttribute: {
     value: function (attr) {
       var component = VRComponents[attr];
@@ -298,9 +306,11 @@ var proto = {
   },
 
   /**
-   * Returns the computed attribute from the element itself,
-   * applied mixins and default values
-   * @type {string} attr - Atrribute name
+   * If attribute is a component, it returns component data including applied
+   * mixins and defaults.
+   *
+   * @param {string} attr
+   * @returns {object|string} Object if component, else string.
    */
   getComputedAttribute: {
     value: function (attr) {