Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #1

Closed
wants to merge 9 commits into from
Closed

Initial implementation #1

wants to merge 9 commits into from

Conversation

michalmuskala
Copy link
Collaborator

No description provided.

{"content-type", "application/x-amz-json-1.1"}
]

ExAws.Operation.JSON.new(:"cognito-idp", data: data, headers: headers)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benwilson512 I tried using :cognito_idp as you suggested, but it failed with signature errors:

%{
  "__type" => "InvalidSignatureException", 
  "message" => "Credential should be scoped to correct service: 'cognito-idp'. "
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we may want to just leave this alone as :"cognito-idp". While slightly less than ergonomic it's rare to actually need to type it, and I'm concerned that it's going to be difficult to try to normalize this at a central place.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's just in 3 places, I'm completely fine with leaving it as :"cognito-idp"

mix.exs Outdated
@@ -0,0 +1,27 @@
defmodule ExAws.Cognito.MixProject do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should be ExAws.CognitoIdp.MixProject right?

mix.exs Outdated

def project do
[
app: :ex_aws_cognito,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be :ex_aws_cognito_idp?

{"content-type", "application/x-amz-json-1.1"}
]

ExAws.Operation.JSON.new(:"cognito-idp", data: data, headers: headers)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we may want to just leave this alone as :"cognito-idp". While slightly less than ergonomic it's rare to actually need to type it, and I'm concerned that it's going to be difficult to try to normalize this at a central place.

@michalmuskala
Copy link
Collaborator Author

@benwilson512 updated

@benwilson512
Copy link
Contributor

benwilson512 commented May 11, 2020

Hi @michalmuskala. If you wish to be a maintainer of ex_aws_cognito_idp I'd be happy to add you, and then you can merge this or any other branch.

@michalmuskala
Copy link
Collaborator Author

Hi Ben. I was primarily interested in this since I used it at the time at a company I worked for. I moved since then and I'm not really interested in maintaining this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants