Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Patch translations #42

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

vincentxavier
Copy link

I've made this work for Sphinx-proof, and the patch should also apply here.

This is related to #13

Currently, this patch only contains french translations.

Signed-off-by: Vincent-Xavier JUMEL <[email protected]>
@welcome
Copy link

welcome bot commented Dec 5, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@vincentxavier vincentxavier changed the title Patch translations [ENH] Patch translations Dec 5, 2021
@vincentxavier vincentxavier marked this pull request as draft December 5, 2021 20:58
@mmcky
Copy link
Member

mmcky commented Dec 6, 2021

Thanks @vincentxavier. I am about to merge #37 which is a pretty extensive rewrite of this package (with the aim to make it more maintainable over the long term) and use more sphinx internals. It is passing all test cases with some minor changes to the title styles. Would love to work with you to fix up #42 once this is merged.

@vincentxavier
Copy link
Author

vincentxavier commented Dec 6, 2021 via email

Signed-off-by: Vincent-Xavier JUMEL <[email protected]>
Signed-off-by: Vincent-Xavier JUMEL <[email protected]>
@mmcky
Copy link
Member

mmcky commented Apr 1, 2022

@vincentxavier I saw that you had made some commits so I have enabled the CI to run for you.

Signed-off-by: Vincent-Xavier JUMEL <[email protected]>
Signed-off-by: Vincent-Xavier JUMEL <[email protected]>
Signed-off-by: Vincent-Xavier JUMEL <[email protected]>
Signed-off-by: Vincent-Xavier JUMEL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants