Add bottle-song
#2384
Merged
Add bottle-song
#2384
+675
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BNAndras Could you try using: |
|
I pulled in the latest main, but that command didn't give me any different output from before. I see the empty files for the test suite, stub file, and example solution that configlet would give me normally, a filled-out csproj, a filled-out .editorconfig, and an updated Exercises.sln. |
BNAndras
force-pushed
the
add-bottle-song
branch
from
f901faf to
a9a8b03
Compare
|
Ah, I might have figured out the issue. I'll work on a fix. |
|
Yeah, I see generated tests now. 🎉 |
BNAndras
force-pushed
the
add-bottle-song
branch
from
a9a8b03 to
bcba0c4
Compare
BNAndras
force-pushed
the
add-bottle-song
branch
from
bcba0c4 to
9d15386
Compare
|
@BNAndras Looks good. I'm working on fixing the test runner properly, so I'll need to hold off on merging this until that is fixed. |
BNAndras
force-pushed
the
add-bottle-song
branch
from
9d15386 to
1361988
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forum.exercism.org/t/add-bottle-song-exercise/15761/2.
This PR also deprecates Beer Song in favor of Bottle Song. The practice exercise generator script gave me blank files, but I was able to cobble together what I needed.