fix(doctor): replace commander-based interactivity check with tty/ci …

…check (#4672)
expo · Mar 28, 2023 · 2c77f63 · 2c77f63
1 parent b679e87
commit 2c77f63
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/packages/expo-doctor/src/utils/env.ts b/packages/expo-doctor/src/utils/env.ts
@@ -1,6 +1,11 @@
 import { boolish } from 'getenv';
 
 class Env {
+  /** Is running in non-interactive CI mode */
+  get CI() {
+    return boolish('CI', false);
+  }
+
   /** Enable debug logging */
   get EXPO_DEBUG() {
     return boolish('EXPO_DEBUG', false);

diff --git a/packages/expo-doctor/src/utils/interactive.ts b/packages/expo-doctor/src/utils/interactive.ts
@@ -0,0 +1,6 @@
+import { env } from './env';
+
+/** Determine if the current process is interactive, and can receive user input */
+export function isInteractive(): boolean {
+  return !env.CI && process.stdout.isTTY;
+}
diff --git a/packages/expo-doctor/src/utils/ora.ts b/packages/expo-doctor/src/utils/ora.ts
@@ -1,7 +1,9 @@
 import chalk from 'chalk';
-import program from 'commander';
 import oraReal, { Ora } from 'ora';
 
+import { env } from './env';
+import { isInteractive } from './interactive';
+
 // eslint-disable-next-line no-console
 const logReal = console.log;
 // eslint-disable-next-line no-console
@@ -19,7 +21,7 @@ const errorReal = console.error;
  */
 export function ora(options?: oraReal.Options | string): oraReal.Ora {
   const inputOptions = typeof options === 'string' ? { text: options } : options || {};
-  const disabled = program.nonInteractive;
+  const disabled = !isInteractive() || env.EXPO_DEBUG;
   const spinner = oraReal({
     // Ensure our non-interactive mode emulates CI mode.
     isEnabled: !disabled,