Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix debugging channels #61

Closed
wants to merge 1 commit into from
Closed

fix debugging channels #61

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2019

  • Remove unnecessary "0" argument to make chan
  • Do not close the debugging channels when the VM completes (for vm: Add basic support for VM instances to be reused (via Reset()) #59)
  • Change VM.Step() to return a channel. This allows the step channel to be
    used from inside a select, so the operation can be aborted by the caller
  • Change VM.Position() to return a read-only channel

- Remove unnecessary "0" argument to make chan
- Do not close the debugging channels when the VM completes (for #59)
- Change VM.Step() to return a channel. This allows the step channel to be
  used from inside a select, so the operation can be aborted by the caller
- Change VM.Position() to return a read-only channel
@antonmedv antonmedv closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant