Better error messages during parsing functional instructions

ezhangle · May 24, 2017 · 56fe3a6 · 56fe3a6
1 parent 451acd4
commit 56fe3a6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,5 +1,9 @@
 ### 0.4.12 (unreleased)
+
+Features:
  * AST: export all attributes to Json format
+ * Inline Assembly: Present proper error message when not supplying enough arguments to a functional
+   instruction.
 
 Bugfixes:
  * Unused variable warnings no longer issued for variables used inside inline assembly

diff --git a/libsolidity/inlineasm/AsmParser.cpp b/libsolidity/inlineasm/AsmParser.cpp
@@ -321,6 +321,15 @@ assembly::Statement Parser::parseCall(assembly::Statement&& _instruction)
 		unsigned args = unsigned(instrInfo.args);
 		for (unsigned i = 0; i < args; ++i)
 		{
+			/// check for premature closing parentheses
+			if (m_scanner->currentToken() == Token::RParen)
+				fatalParserError(string(
+					"Expected " +
+					boost::lexical_cast<string>(args) +
+					" arguments, but received " +
+					boost::lexical_cast<string>(i)
+				));
+
 			ret.arguments.emplace_back(parseExpression());
 			if (i != args - 1)
 			{