Merge pull request escoz#670 from luketheobscure/delete_support

Change willDeleteElement: to shouldDeleteElement:
face · Apr 14, 2014 · b1ab112 · b1ab112
2 parents 7742c4e + f5aae3c
commit b1ab112
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/quickdialog/QuickDialogController.h b/quickdialog/QuickDialogController.h
@@ -52,9 +52,9 @@
 + (QuickDialogController *)controllerForRoot:(QRootElement *)root;
 
 /**
- Called before a cell is removed from the tableView.
+ Called before a cell is removed from the tableView. Return YES and QuickDialog will delete the cell, return NO if you want to delete the cell or reload the tableView yourself.
 */
-- (void)willDeleteElement:(QElement *)element;
+- (BOOL)shouldDeleteElement:(QElement *)element;
 
 + (UINavigationController *)controllerWithNavigationForRoot:(QRootElement *)root;
 

diff --git a/quickdialog/QuickDialogController.m b/quickdialog/QuickDialogController.m
@@ -148,8 +148,8 @@ - (QuickDialogController *)controllerForRoot:(QRootElement *)root {
     return [QuickDialogController buildControllerWithClass:controllerClass root:root];
 }
 
-- (void)willDeleteElement:(QElement *)element{
-    // Intentionally empty.
+- (BOOL)shouldDeleteElement:(QElement *)element{
+    return YES;
 }
 
 - (void) resizeForKeyboard:(NSNotification*)aNotification {

diff --git a/quickdialog/QuickDialogDataSource.m b/quickdialog/QuickDialogDataSource.m
@@ -64,8 +64,10 @@ - (void)tableView:(UITableView *)tableView commitEditingStyle:(UITableViewCellEd
         element = section.elements[indexPath.row];
     }
 
-    if ([element.controller respondsToSelector:@selector(willDeleteElement:)]) {
-        [(QuickDialogController *)element.controller willDeleteElement:element];
+    if ([element.controller respondsToSelector:@selector(shouldDeleteElement:)]) {
+        if (![(QuickDialogController *)element.controller shouldDeleteElement:element]) {
+            return;
+        };
     }
 
     if ([section removeElementForRow:indexPath.row]){

diff --git a/sample/ExampleViewController.m b/sample/ExampleViewController.m
@@ -69,8 +69,9 @@ - (void)displayViewControllerForRoot:(QRootElement *)element {
     }
 }
 
--(void)willDeleteElement:(QElement *)element{
-    // Optionally you could remove the element from your data source here.
+-(BOOL)shouldDeleteElement:(QElement *)element{
+    // Return no if you want to delete the cell or redraw the tableView yourself
+    return YES;
 }