Make model/generator wrappers search for the object name instead of looking in a strategy #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bookresearch#598) Summary: All acqf generators now look for their acqf within their own section. Update acqf generators to all use default option finders. Reviewed By: crasanders Differential Revision: D68976692
…ooking in a strategy Summary: Strategies used to try to initialize model/generator wrappers by passing a name. We change this to pass the model/generator names instead and the wrappers themselves will handle finding the required object. Differential Revision: D68986197
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68986197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Strategies used to try to initialize model/generator wrappers by passing a name. We change this to pass the model/generator names instead and the wrappers themselves will handle finding the required object.
Differential Revision: D68986197