Skip to content

Commit

Permalink
Add PL UDP binary to build and release (#1635)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1635

Following step 4 in https://www.internalfb.com/intern/wiki/Private_Computation_Infra/Private_Services_Infra/PCS_wikis/How_to_add_a_stage_to_PCS/Step_4:_Update_Github_CI/.

This extracts the binaries and uploads it to onedocker under private_lift/pcf2_lift_metadata_compaction

Reviewed By: ajinkya-ghonge

Differential Revision: D39749359

fbshipit-source-id: 02b6c2bbd4ebb7b7fafa68e5fd88f20a13d609c5
  • Loading branch information
Tal Davidi authored and facebook-github-bot committed Sep 30, 2022
1 parent 28485c7 commit 8dc3b06
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions binaries_out_lists/emp_games.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
lift_calculator
pcf2_lift_calculator
pcf2_lift_metadata_compaction
pcf2_shard_combiner
decoupled_attribution_calculator
decoupled_aggregation_calculator
Expand Down
1 change: 1 addition & 0 deletions docker/emp_games/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ target_link_libraries(
perftools
pcf2_lift_input_processing
)
install(TARGETS pcf2_lift_metadata_compaction DESTINATION bin)

# pcf2_lift
file(GLOB pcf2_lift_calculator_src
Expand Down
1 change: 1 addition & 0 deletions extract-docker-binaries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ if [ "$PACKAGE" = "emp_games" ]; then
docker create -ti --name temp_container "${DOCKER_IMAGE_PATH}"
docker cp temp_container:/usr/local/bin/lift_calculator "$SCRIPT_DIR/binaries_out/."
docker cp temp_container:/usr/local/bin/pcf2_lift_calculator "$SCRIPT_DIR/binaries_out/."
docker cp temp_container:/usr/local/bin/pcf2_lift_metadata_compaction "$SCRIPT_DIR/binaries_out/."
docker cp temp_container:/usr/local/bin/decoupled_attribution_calculator "$SCRIPT_DIR/binaries_out/."
docker cp temp_container:/usr/local/bin/decoupled_aggregation_calculator "$SCRIPT_DIR/binaries_out/."
docker cp temp_container:/usr/local/bin/pcf2_attribution_calculator "$SCRIPT_DIR/binaries_out/."
Expand Down
1 change: 1 addition & 0 deletions promote_scripts/promote_binaries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ fi
binary_names=(
'private_lift/lift'
'private_lift/pcf2_lift'
'private_lift/pcf2_lift_metadata_compaction'
'private_lift/aggregator'
'private_attribution/decoupled_attribution'
'private_attribution/decoupled_aggregation'
Expand Down
2 changes: 2 additions & 0 deletions upload-binaries-to-s3-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ shift
one_docker_repo="one-docker-repository-custom"
lift_package="s3://$one_docker_repo/private_lift/lift/${TAG}/lift"
pcf2_lift_package="s3://$one_docker_repo/private_lift/pcf2_lift/${TAG}/pcf2_lift"
pcf2_lift_metadata_compaction_package="s3://$one_docker_repo/private_lift/pcf2_lift_metadata_compaction/${TAG}/pcf2_lift_metadata_compaction"
attribution_repo="s3://$one_docker_repo/private_attribution"
decoupled_attribution="$attribution_repo/decoupled_attribution/${TAG}/decoupled_attribution"
decoupled_aggregation="$attribution_repo/decoupled_aggregation/${TAG}/decoupled_aggregation"
Expand All @@ -47,6 +48,7 @@ if [ "$PACKAGE" = "emp_games" ]; then
cd binaries_out || exit
aws s3 cp lift_calculator "$lift_package"
aws s3 cp pcf2_lift_calculator "$pcf2_lift_package"
aws s3 cp pcf2_lift_metadata_compaction "$pcf2_lift_metadata_compaction_package"
aws s3 cp decoupled_attribution_calculator "$decoupled_attribution"
aws s3 cp decoupled_aggregation_calculator "$decoupled_aggregation"
aws s3 cp pcf2_attribution_calculator "$pcf2_attribution"
Expand Down
2 changes: 2 additions & 0 deletions upload-binaries-to-s3.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ shift
one_docker_repo="one-docker-repository-prod"
lift_package="s3://$one_docker_repo/private_lift/lift/${TAG}/lift"
pcf2_lift_package="s3://$one_docker_repo/private_lift/pcf2_lift/${TAG}/pcf2_lift"
pcf2_lift_metadata_compaction_package="s3://$one_docker_repo/private_lift/pcf2_lift_metadata_compaction${TAG}/pcf2_lift_metadata_compaction"
attribution_repo="s3://$one_docker_repo/private_attribution"
decoupled_attribution="$attribution_repo/decoupled_attribution/${TAG}/decoupled_attribution"
decoupled_aggregation="$attribution_repo/decoupled_aggregation/${TAG}/decoupled_aggregation"
Expand All @@ -47,6 +48,7 @@ if [ "$PACKAGE" = "emp_games" ]; then
cd binaries_out || exit
aws s3 cp lift_calculator "$lift_package"
aws s3 cp pcf2_lift_calculator "$pcf2_lift_package"
aws s3 cp pcf2_lift_metadata_compaction "$pcf2_lift_metadata_compaction_package"
aws s3 cp decoupled_attribution_calculator "$decoupled_attribution"
aws s3 cp decoupled_aggregation_calculator "$decoupled_aggregation"
aws s3 cp pcf2_attribution_calculator "$pcf2_attribution"
Expand Down

0 comments on commit 8dc3b06

Please sign in to comment.