Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorchMultimodal][chore] Fix import sorting inconsistency #12

Closed
wants to merge 4 commits into from

Conversation

ebsmothers
Copy link
Contributor

@ebsmothers ebsmothers commented Apr 4, 2022

Stack from ghstack (oldest at bottom):

Changes in this PR:

  • Disable first_party_detection in usort
  • Update CONTRIBUTING with black and usort versions
  • Run ufmt on the entire repo to fix import order issues

Differential Revision: D35377751

Changes in this PR:
- Disable first_party_detection in usort
- Update CONTRIBUTING with black and usort versions
- Run ufmt on the entire repo to fix import order issues

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2022
ebsmothers added a commit that referenced this pull request Apr 4, 2022
Changes in this PR:
- Disable first_party_detection in usort
- Update CONTRIBUTING with black and usort versions
- Run ufmt on the entire repo to fix import order issues

ghstack-source-id: 88ce69e3f96cbbab7f1eb3e019134168c8faabad
Pull Request resolved: #12
@ebsmothers
Copy link
Contributor Author

@ebsmothers has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Changes in this PR:
- Disable first_party_detection in usort
- Update CONTRIBUTING with black and usort versions
- Run ufmt on the entire repo to fix import order issues

Differential Revision: [D35377751](https://our.internmc.facebook.com/intern/diff/D35377751)

[ghstack-poisoned]
ankitade added a commit that referenced this pull request Apr 6, 2022
Changes in this PR:
- Disable first_party_detection in usort
- Update CONTRIBUTING with black and usort versions
- Run ufmt on the entire repo to fix import order issues

ghstack-source-id: 42abea75ba8b53bccc2811a9ea1687e01fd2a9c6
Pull Request resolved: #12
@ebsmothers
Copy link
Contributor Author

@ebsmothers has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Changes in this PR:
- Disable first_party_detection in usort
- Update CONTRIBUTING with black and usort versions
- Run ufmt on the entire repo to fix import order issues

Differential Revision: [D35377751](https://our.internmc.facebook.com/intern/diff/D35377751)

[ghstack-poisoned]
ebsmothers added a commit that referenced this pull request Apr 6, 2022
Changes in this PR:
- Disable first_party_detection in usort
- Update CONTRIBUTING with black and usort versions
- Run ufmt on the entire repo to fix import order issues

ghstack-source-id: ace0ad7272db424341de428181ed1b876efa0692
Pull Request resolved: #12
@ebsmothers
Copy link
Contributor Author

@ebsmothers has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Changes in this PR:
- Disable first_party_detection in usort
- Update CONTRIBUTING with black and usort versions
- Run ufmt on the entire repo to fix import order issues

Differential Revision: [D35377751](https://our.internmc.facebook.com/intern/diff/D35377751)

[ghstack-poisoned]
ebsmothers added a commit that referenced this pull request Apr 6, 2022
Changes in this PR:
- Disable first_party_detection in usort
- Update CONTRIBUTING with black and usort versions
- Run ufmt on the entire repo to fix import order issues

ghstack-source-id: 7fc15e8068d1fbfcef2afcd968073c828669ac02
Pull Request resolved: #12
@ebsmothers
Copy link
Contributor Author

@ebsmothers has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot deleted the gh/ebsmothers/1/head branch April 11, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants