Skip to content

Commit

Permalink
stop sending x-peer-id in peerconnection_server
Browse files Browse the repository at this point in the history
the comment about why that is not a thing dates from 2013.

BUG=None

Change-Id: I97ec5090fc1acb4361bc8472fe605dafea89aa1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183545
Reviewed-by: Tommi <[email protected]>
Commit-Queue: Philipp Hancke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#32267}
  • Loading branch information
fippo authored and Commit Bot committed Oct 1, 2020
1 parent e99c68d commit 0240cf8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions examples/peerconnection/client/peer_connection_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,7 @@ bool PeerConnectionClient::ParseServerResponse(const std::string& response,

*peer_id = -1;

// See comment in peer_channel.cc for why we use the Pragma header and
// not e.g. "X-Peer-Id".
// See comment in peer_channel.cc for why we use the Pragma header.
GetHeaderValue(response, *eoh, "\r\nPragma: ", peer_id);

return true;
Expand Down
2 changes: 1 addition & 1 deletion examples/peerconnection/server/data_socket.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const char DataSocket::kCrossOriginAllowHeaders[] =
"Access-Control-Allow-Methods: POST, GET, OPTIONS\r\n"
"Access-Control-Allow-Headers: Content-Type, "
"Content-Length, Connection, Cache-Control\r\n"
"Access-Control-Expose-Headers: Content-Length, X-Peer-Id\r\n";
"Access-Control-Expose-Headers: Content-Length\r\n";

#if defined(WIN32)
class WinsockInitializer {
Expand Down

0 comments on commit 0240cf8

Please sign in to comment.