-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customizing URI options more #126
base: master
Are you sure you want to change the base?
Conversation
63ddbda
to
f9dfc2a
Compare
f9dfc2a
to
d15bc89
Compare
Hi, sorry, but do you have time to finish the pull request? Thank you so much |
Hi, I'll try to complete it in the next few weeks |
Thank you so much! |
3d9ef15
to
fe1a975
Compare
fe1a975
to
c7a9996
Compare
Hey @bruno-buiret, thank you for opening the issue, we're almost there. Before merging this, would you give use some feedback? Does this satisfy all your needs? You can install it with:
The branch is rebased on 1.6.2 so that everything is up to date. Thank you in advance |
@ilario-pierbattista, so sorry, work has been kind of hectic. I just created a basic Symfony 7.2 application with PHP 8.4 and added the bundle with the Composer command you provided. I was able to customize the A few questions if I may,
interface UriOptionsInterface
{
/**
* ...
*/
public function buildUriOptions(array $clientConfiguration, string $clientName): array;
}
$conf['driverOptions'] = [];
if ($this->driverOptionsService instanceof DriverOptionsInterface) {
$conf['driverOptions'] = $this->driverOptionsService->buildDriverOptions($conf);
}
Thank you so much for this and I hope this help! |
This PR resolve the issue #125