Compile project statically in MinGW environment #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC analyzer wrongly assumes that `if(cp == NULL || c == ':')` not guarding against `cp++`.
In order to achieve more portability int2ssl needs to compiled with `-static` option in MinGW environment, so all required toolchain libraries gets compiled into binary. Partially fixes falltergeist#6. Now project supports cross-compiling for Windows binaries in Linux host. To do so, pass `-DCMAKE_TOOLCHAIN_FILE=/path/to/Toolchain-MinGW64.cmake` on cmake configuration phase. Also reorganized CMakeLists.txt file for more modern CMake project best practies usage: * -Os (optimized for size) is part of Cmake's MinSizeRel build type, so this option should'nt defined manually. Instead use `-DCMAKE_BUILD_TYPE=MinSizeRel`. * -s (strip binary option) is not true crossplatform option, so moved it into option STRIP_EXE enabled by default. * Minimal CMake version requirement updated to 3.13 to avoid deprecation warnings on modern cmake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to achieve more portability int2ssl needs to compiled with
-staticoption in MinGW environment, so all required toolchain libraries gets compiled into binary. Partially fixes #6.Now project supports cross-compiling for Windows binaries in Linux host. To do so, pass
-DCMAKE_TOOLCHAIN_FILE=/path/to/Toolchain-MinGW64.cmakeon cmake configuration phase.Also reorganized CMakeLists.txt file for more modern CMake project best practies usage:
-DCMAKE_BUILD_TYPE=MinSizeRel.Additionally implemented GitHub Actions flows.