Skip to content

Commit

Permalink
Small performance improvement. The current code is correct, but if it…
Browse files Browse the repository at this point in the history
… is used inside a long loop or long strings, it's inefficient.
  • Loading branch information
klaussilveira committed Apr 3, 2012
1 parent 14f120d commit 16bd110
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions main/rfc1867.c
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ static int multipart_buffer_headers(multipart_buffer *self, zend_llist *header T

/* get lines of text, or CRLF_CRLF */

while( (line = get_line(self TSRMLS_CC)) && strlen(line) > 0 )
while( (line = get_line(self TSRMLS_CC)) && line[0] != '\0' )
{
/* add header to table */
char *key = line;
Expand Down Expand Up @@ -979,7 +979,7 @@ SAPI_API SAPI_POST_HANDLER_FUNC(rfc1867_post_handler) /* {{{ */
continue;
}

if (strlen(filename) == 0) {
if (filename[0] == '\0') {
#if DEBUG_FILE_UPLOAD
sapi_module.sapi_error(E_NOTICE, "No file uploaded");
#endif
Expand Down Expand Up @@ -1063,12 +1063,12 @@ SAPI_API SAPI_POST_HANDLER_FUNC(rfc1867_post_handler) /* {{{ */

if (!cancel_upload && !end) {
#if DEBUG_FILE_UPLOAD
sapi_module.sapi_error(E_NOTICE, "Missing mime boundary at the end of the data for file %s", strlen(filename) > 0 ? filename : "");
sapi_module.sapi_error(E_NOTICE, "Missing mime boundary at the end of the data for file %s", filename[0] != '\0' ? filename : "");
#endif
cancel_upload = UPLOAD_ERROR_C;
}
#if DEBUG_FILE_UPLOAD
if (strlen(filename) > 0 && total_bytes == 0 && !cancel_upload) {
if (filename[0] != '\0' && total_bytes == 0 && !cancel_upload) {
sapi_module.sapi_error(E_WARNING, "Uploaded file size 0 - file [%s=%s] not saved", param, filename);
cancel_upload = 5;
}
Expand Down

0 comments on commit 16bd110

Please sign in to comment.