Skip to content

Commit

Permalink
Merge branch '5.4'
Browse files Browse the repository at this point in the history
  • Loading branch information
cataphract committed Apr 7, 2012
2 parents 7497aa9 + f7d4076 commit bd5f52f
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 2 deletions.
27 changes: 27 additions & 0 deletions ext/standard/tests/streams/stream_get_line_NUL_delimiter.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
--TEST--
Bug #60455: stream_get_line and \0 as a delimiter
--FILE--
<?php
class TestStream {
private $s = 0;
function stream_open($path, $mode, $options, &$opened_path) {
return true;
}
function stream_read($count) {
if ($this->s++ == 0)
return "a\0";

return "";
}
function stream_eof() {
return $this->s >= 2;
}

}

stream_wrapper_register("test", "TestStream");

$f = fopen("test://", "r");
var_dump(stream_get_line($f, 100, "\0"));
--EXPECT--
string(1) "a"
4 changes: 2 additions & 2 deletions main/streams/streams.c
Original file line number Diff line number Diff line change
Expand Up @@ -1023,8 +1023,8 @@ PHPAPI char *php_stream_get_record(php_stream *stream, size_t maxlen, size_t *re
char *ret_buf, /* returned buffer */
*found_delim = NULL;
size_t buffered_len,
tent_ret_len; /* tentative returned length*/
int has_delim = delim_len > 0 && delim[0] != '\0';
tent_ret_len; /* tentative returned length */
int has_delim = delim_len > 0;

if (maxlen == 0) {
return NULL;
Expand Down

0 comments on commit bd5f52f

Please sign in to comment.