-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add long sms concat info for received sms #93
Open
yurenchen000
wants to merge
181
commits into
faucamp:master
Choose a base branch
from
yurenchen000:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the manipulation of PDP contexts (setting APNs, etc) and can initiate the first portion of a data session (the actual dialing). Not much use as-is, but can be extended later for MMS sending functionality, and with the use of pppd and a bit of hacking this can be used to set up and control "normal" data network connections via the GSM modem.
+CREG: 2,1,"1727","0000C7EE" is now parsed correctly
Taken from faucamp#39 Unit test won't work, a huge work is needed to completely port to python 3. But at least we have something working.
Thus we can handle continuations e.g.
change typo on checkFowarding
param fwdNumber
Should have no parameters.
Included self parameter
Just initialize the GsmModem object with requestDelivery=False (default is True)
…), added AT_CNMI property to GsmModem. The waittingForModemToStartInSeconds arg allows to wait after the serial connection has started, and before sending the AT commands. The AT_CNMI proprety of the GsmModem class allow to specify the CNMI parameter of the gsm modem, this helps to set up the incoming sms notifications.
Unnecessary semicolon removed
Empty self.write() with no args removed, closes faucamp#43
HUAWEI CEND notification format fix
_placeHolderCallback removed. If there is no callback set, callback variable is None. That means it is now simple to test if the callback is set or not. Some parts of the code were using this method (if someCallbackFunc is None) for a longer period of time anyway.
This is not a fix and does not add any functionality. I made changes to a way of calling callback so it reflects recent changes in modem.py.
Fix for issue faucamp#51, which was also affecting my environment. This modifies the ReceivedSms class so that there's access to the message index, which makes it possible to call things like deleteStoredSms without having to guess at the index.
add `concat` property for received sms //get Concantion from pdu `smsDict['udh']`
Add `concat` property for `ReceivedSms`: - Get Concantion from pdu `smsDict['udh']` - Update examples/sms_handler_demo.py
All checks have failed, Cause travis-ci
|
This repository was abandoned a while ago. Could you create the PR to this updated fork? |
Getting an SMS index/SMS deletion
Fix supportedCommands property for Teleofis modems
@yurenchen000 please post PRs to the maintained fork of python-gsmmodem. Great addition by the way! |
Fix connect for modem's which don't support AT+DDET command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
concat
property forReceivedSms
:smsDict['udh']
examples/sms_handler_demo.py
test output of sms_handler_demo.py