pty: Fix allocation failure double free

The updating and moving around of the pty code added a bug where both the helper and caller free the main tty struct (the pty driver must free the o_tty pair itself however). Signed-off-by: Alan Cox <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
faux123 · Oct 13, 2008 · 335adde · 335adde
1 parent fe9cd96
commit 335adde
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/drivers/char/pty.c b/drivers/char/pty.c
@@ -544,8 +544,6 @@ static int pty_unix98_install(struct tty_driver *driver, struct tty_struct *tty)
 	module_put(o_tty->driver->owner);
 	free_tty_struct(o_tty);
 	pty_unix98_shutdown(tty);
-	free_tty_struct(tty);
-	module_put(driver->owner);
 	return -ENOMEM;
 }