Skip to content

Commit

Permalink
palm_bk3710: improve IDE registration
Browse files Browse the repository at this point in the history
* fix device tree ... don't forget to set the parent device

* let init/exit code be removed where practical

Signed-off-by: David Brownell <[email protected]>
[bart: splitted it from bigger DaVinci patch, s/hw.parent/hw.dev/]
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
  • Loading branch information
David Brownell authored and bzolnier committed Sep 2, 2008
1 parent 96f8021 commit bfc2f01
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/ide/arm/palm_bk3710.c
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ static struct ide_port_info __devinitdata palm_bk3710_port_info = {
.mwdma_mask = ATA_MWDMA2,
};

static int __devinit palm_bk3710_probe(struct platform_device *pdev)
static int __init palm_bk3710_probe(struct platform_device *pdev)
{
struct clk *clk;
struct resource *mem, *irq;
Expand Down Expand Up @@ -389,6 +389,7 @@ static int __devinit palm_bk3710_probe(struct platform_device *pdev)
hw.io_ports_array[i] = base + IDE_PALM_ATA_PRI_REG_OFFSET + i;
hw.io_ports.ctl_addr = base + IDE_PALM_ATA_PRI_CTL_OFFSET;
hw.irq = irq->start;
hw.dev = &pdev->dev;
hw.chipset = ide_palm3710;

palm_bk3710_port_info.udma_mask = rate < 100000000 ? ATA_UDMA4 :
Expand All @@ -412,13 +413,11 @@ static struct platform_driver platform_bk_driver = {
.name = "palm_bk3710",
.owner = THIS_MODULE,
},
.probe = palm_bk3710_probe,
.remove = NULL,
};

static int __init palm_bk3710_init(void)
{
return platform_driver_register(&platform_bk_driver);
return platform_driver_probe(&platform_bk_driver, palm_bk3710_probe);
}

module_init(palm_bk3710_init);
Expand Down

0 comments on commit bfc2f01

Please sign in to comment.