-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network interface binding documentation #1008
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 62 62
Lines 3366 3366
=======================================
Hits 3196 3196
Misses 158 158
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thank you. I have two broad suggestions:
Also, I think this is significant enough that you should list yourself in |
Updated.
I don't follow. I'm not familiar with any OS level quotas that'd affect this. |
I wasn't being clear—I was talking about |
Makes sense. I've added a note in the docs. |
Co-authored-by: favonia <[email protected]> Signed-off-by: Mohsen Rezaei <[email protected]>
@mohsenrezaeithe Thank you for your contribution! ❤️ |
Fixes #1006
This would help users of the Docker container approach to be able to bind their updater to a specific network interface and get the right public IP.