FIX: Don't track user profile view when viewed by system user.

fbxie · Aug 23, 2016 · 17f0727 · 17f0727
1 parent f192326
commit 17f0727
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/app/models/user_profile_view.rb b/app/models/user_profile_view.rb
@@ -7,6 +7,7 @@ def self.add(user_profile_id, ip, user_id=nil, at=nil, skip_redis=false)
     at ||= Time.zone.now
     redis_key = "user-profile-view:#{user_profile_id}:#{at.to_date}"
     if user_id
+      return if user_id < 1
       redis_key << ":user-#{user_id}"
     else
       redis_key << ":ip-#{ip}"

diff --git a/spec/models/user_profile_view_spec.rb b/spec/models/user_profile_view_spec.rb
@@ -36,4 +36,9 @@ def add(user_profile_id, ip, user_id=nil, at=nil)
       expect(described_class.count).to eq(1)
     end
   end
+
+  it "should not create a profile view for the system user" do
+    add(user_profile_id, '1.1.1.1', Discourse::SYSTEM_USER_ID)
+    expect(described_class.count).to eq(0)
+  end
 end