Update or remove any remaining references to viewvc/blink.

[email protected], [email protected] BUG=617246 Review-Url: https://codereview.chromium.org/2471733003 Cr-Commit-Position: refs/heads/master@{#429438}
feiyue1206 · Nov 2, 2016 · 041e8a4 · 041e8a4
1 parent 68d8a74
commit 041e8a4
Show file tree

Hide file tree

Showing 12 changed files with 14 additions and 21 deletions.
diff --git a/content/common/page_state_serialization.cc b/content/common/page_state_serialization.cc
@@ -83,12 +83,12 @@ bool AppendReferencedFilesFromDocumentState(
   if (document_state.empty())
     return true;
 
-  // This algorithm is adapted from Blink's core/html/FormController.cpp code.
+  // This algorithm is adapted from Blink's FormController code.
   // We only care about how that code worked when this code snapshot was taken
   // as this code is only needed for backwards compat.
   //
-  // For reference, see FormController::formStatesFromStateVector at:
-  // http://src.chromium.org/viewvc/blink/trunk/Source/core/html/FormController.cpp?pathrev=152274
+  // For reference, see FormController::formStatesFromStateVector in
+  // third_party/WebKit/Source/core/html/forms/FormController.cpp.
 
   size_t index = 0;
 

diff --git a/media/tools/layout_tests/layouttest_analyzer.py b/media/tools/layout_tests/layouttest_analyzer.py
@@ -14,7 +14,7 @@
 import layouttest_analyzer_helpers
 from layouttest_analyzer_helpers import DEFAULT_REVISION_VIEW_URL
 import layouttests
-from layouttests import DEFAULT_LAYOUTTEST_SVN_VIEW_LOCATION
+from layouttests import DEFAULT_LAYOUTTEST_LOCATION
 
 from test_expectations import TestExpectations
 from trend_graph import TrendGraph
@@ -322,7 +322,7 @@ def UpdateTrendGraph(start_time, analyzer_result_map, diff_map, simple_rev_str,
           test_str += name + ','
           # This is link to test HTML in SVN.
           links += ('<a href="%s%s">%s</a>' %
-                    (DEFAULT_LAYOUTTEST_SVN_VIEW_LOCATION, name, name))
+                    (DEFAULT_LAYOUTTEST_LOCATION, name, name))
       if test_str:
         anno = '\'' + test_str + '\''
         # The annotation of passing rate is a union of all annotations.

diff --git a/media/tools/layout_tests/layouttest_analyzer_helpers.py b/media/tools/layout_tests/layouttest_analyzer_helpers.py
@@ -24,7 +24,6 @@
     'trunk/LayoutTests/platform/chromium/test_expectations.txt')
 REVISION_LOG_URL = ('http://build.chromium.org/f/chromium/perf/dashboard/ui/'
     'changelog_blink.html?url=/trunk/LayoutTests/%s&range=%d:%d')
-DEFAULT_REVISION_VIEW_URL = 'http://src.chromium.org/viewvc/blink?revision=%s'
 
 
 class AnalyzerResultMap:

diff --git a/media/tools/layout_tests/layouttests.py b/media/tools/layout_tests/layouttests.py
@@ -17,12 +17,9 @@
 
 import pysvn
 
-# LayoutTests SVN root location.
 DEFAULT_LAYOUTTEST_LOCATION = (
-    'http://src.chromium.org/blink/trunk/LayoutTests/')
-# LayoutTests SVN view link
-DEFAULT_LAYOUTTEST_SVN_VIEW_LOCATION = (
-    'http://src.chromium.org/viewvc/blink/trunk/LayoutTests/')
+   'https://chromium.googlesource.com/chromium/src/'
+   '+/master/third_party/WebKit/LayoutTests/')
 
 
 # When parsing the test HTML file and finding the test description,

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/template_expander.py b/mojo/public/tools/bindings/pylib/mojom/generate/template_expander.py
@@ -2,8 +2,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-# Based on:
-# http://src.chromium.org/viewvc/blink/trunk/Source/build/scripts/template_expander.py
+# Based on third_party/WebKit/Source/build/scripts/template_expander.py.
 
 import imp
 import os.path

diff --git a/...ty/WebKit/LayoutTests/http/tests/history/reload-during-load-after-load-event-expected.txt b/...ty/WebKit/LayoutTests/http/tests/history/reload-during-load-after-load-event-expected.txt
@@ -1,4 +1,4 @@
-This tests starting a new resource load after the load event has finished, then reloading while that load is still in progress. Due to a regression in http://src.chromium.org/viewvc/blink?revision=148684&view=revision, we would overwrite the load type such that the reload will still be executed correctly, but the history entry will be created as though it was a standard load.
+This tests starting a new resource load after the load event has finished, then reloading while that load is still in progress. Due to a regression in https://chromium.googlesource.com/chromium/src/+/8b913deb7165a50daa13e6b64300e550cf62a47e, we would overwrite the load type such that the reload will still be executed correctly, but the history entry will be created as though it was a standard load.
 
 ============== Back Forward List ==============
 curr->  http://127.0.0.1:8000/history/reload-during-load-after-load-event.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/history/reload-during-load-after-load-event.html b/third_party/WebKit/LayoutTests/http/tests/history/reload-during-load-after-load-event.html
@@ -1,7 +1,7 @@
 <html>
 <body onload="setTimeout(test, 0);">
 This tests starting a new resource load after the load event has finished, then reloading while that load is still in progress.
-Due to a regression in http://src.chromium.org/viewvc/blink?revision=148684&view=revision, we would overwrite the load type such that
+Due to a regression in https://chromium.googlesource.com/chromium/src/+/8b913deb7165a50daa13e6b64300e550cf62a47e, we would overwrite the load type such that
 the reload will still be executed correctly, but the history entry will be created as though it was a standard load.
 <script>
 if (window.testRunner) {

diff --git a/third_party/WebKit/LayoutTests/http/tests/misc/form-base-target-blank-expected.txt b/third_party/WebKit/LayoutTests/http/tests/misc/form-base-target-blank-expected.txt
@@ -1,5 +1,5 @@
 Test that if a form is submitted from a document with a base element that sets a target,
 the form's target attribute takes precedence over the base's target attribute.
-This was regressed in http://src.chromium.org/viewvc/blink/?view=revision&revision=153933
+This was regressed in https://chromium.googlesource.com/chromium/src/+/65389334354b996ae8490706d84d5848f5f023e7
 This test will timeout if it fails.
 
diff --git a/third_party/WebKit/LayoutTests/http/tests/misc/resources/form-base-target-blank.html b/third_party/WebKit/LayoutTests/http/tests/misc/resources/form-base-target-blank.html
@@ -1,7 +1,7 @@
 <body>
 Test that if a form is submitted from a document with a base element that sets a target,<br>
 the form's target attribute takes precedence over the base's target attribute.<br>
-This was regressed in http://src.chromium.org/viewvc/blink/?view=revision&revision=153933<br>
+This was regressed in https://chromium.googlesource.com/chromium/src/+/65389334354b996ae8490706d84d5848f5f023e7<br>
 This test will timeout if it fails.<br>
 <script>
 if (window.testRunner)

diff --git a/..._party/WebKit/LayoutTests/paint/invalidation/non-text-link-invalidation-optimization.html b/..._party/WebKit/LayoutTests/paint/invalidation/non-text-link-invalidation-optimization.html
@@ -13,7 +13,7 @@
     }
 </style>
 
-<!-- Ensure the optimization in https://src.chromium.org/viewvc/blink?view=rev&revision=152046 doesn't break. -->
+<!-- Ensure the optimization in https://chromium.googlesource.com/chromium/src/+/b5569d06160fcc6a907d3f41416c7ab1bb4fbcda doesn't break. -->
 <div id="div">
 This test <img src="resources/bluesquare.png" width="10px" height="10px"> passes if <span>only</span> text is invalidated and <img src="resources/bluesquare.png" width="10px" height="10px"> no <img src="resources/bluesquare.png" width="10px" height="10px"> images.
 </div>

diff --git a/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/PrettyPatch.rb b/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/PrettyPatch.rb
@@ -87,7 +87,7 @@ def self.diff_header?(line)
 
     SMALLEST_EQUAL_OPERATION = 3
 
-    OPENSOURCE_URL = "http://src.chromium.org/viewvc/blink/"
+    OPENSOURCE_URL = "https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/"
 
     OPENSOURCE_DIRS = Set.new %w[
         LayoutTests

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
@@ -91033,8 +91033,6 @@ value.
 <enum name="MappedCSSProperties" type="int">
 <!-- Generated from third_party/WebKit/Source/core/frame/UseCounter.cpp -->
 
-<!-- See http://src.chromium.org/viewvc/blink/trunk/Source/core/page/UseCounter.cpp -->
-
   <int value="1" label="Total Pages Measured"/>
   <int value="2" label="color"/>
   <int value="3" label="direction"/>