Skip to content

Commit

Permalink
Completely disable MultiProfileDownloadNotificationTest.DownloadMulti…
Browse files Browse the repository at this point in the history
…pleFiles

It turns out this test's flakiness is due to its setup, so my
previous attempt to early-out didn't actually fix it. This time I'm
completely disabling the test. I've made progress on fixing the
underlying issue, but I'll wait on sending that out until I can
reproduce it somewhere.

Bug: 933963
Change-Id: I89b0bfa3f94d32b9fc84943ab2d73217ae40d3fe
Reviewed-on: https://chromium-review.googlesource.com/c/1479885
Reviewed-by: Min Qin <[email protected]>
Commit-Queue: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/heads/master@{#634317}
  • Loading branch information
robbiemc authored and Commit Bot committed Feb 21, 2019
1 parent e645895 commit 0be4dde
Showing 1 changed file with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1059,19 +1059,12 @@ class MultiProfileDownloadNotificationTest

IN_PROC_BROWSER_TEST_F(MultiProfileDownloadNotificationTest,
PRE_DownloadMultipleFiles) {
// TODO(crbug.com/933963): Flaky with network service.
if (base::FeatureList::IsEnabled(network::features::kNetworkService))
return;

AddAllUsers();
}

// TODO(crbug.com/933963): Flaky with network service.
IN_PROC_BROWSER_TEST_F(MultiProfileDownloadNotificationTest,
DownloadMultipleFiles) {
// TODO(crbug.com/933963): Flaky with network service.
if (base::FeatureList::IsEnabled(network::features::kNetworkService))
return;

DISABLED_DownloadMultipleFiles) {
AddAllUsers();

GURL url(SlowDownloadInterceptor::kUnknownSizeUrl);
Expand Down

0 comments on commit 0be4dde

Please sign in to comment.