Add UUID for BaseAudioContext

For the future DevTool integration, we need a unique identifier for each BaseAudioContext. This CL generate a UUID for BaseAudioContext at its construction time. Bug: 862411 Change-Id: I2dda45611af21d57820e1539b22091deb8ddf443 Reviewed-on: https://chromium-review.googlesource.com/1132419 Commit-Queue: Hongchan Choi <[email protected]> Reviewed-by: Raymond Toy <[email protected]> Cr-Commit-Position: refs/heads/master@{#574204}
feiyue1206 · Jul 11, 2018 · 0f728d0 · 0f728d0
1 parent 19ab2ed
commit 0f728d0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/third_party/blink/renderer/modules/webaudio/base_audio_context.cc b/third_party/blink/renderer/modules/webaudio/base_audio_context.cc
@@ -69,6 +69,7 @@
 #include "third_party/blink/renderer/modules/webaudio/script_processor_node.h"
 #include "third_party/blink/renderer/modules/webaudio/stereo_panner_node.h"
 #include "third_party/blink/renderer/modules/webaudio/wave_shaper_node.h"
+#include "third_party/blink/renderer/platform/uuid.h"
 #include "third_party/blink/renderer/platform/audio/iir_filter.h"
 #include "third_party/blink/renderer/platform/bindings/exception_state.h"
 #include "third_party/blink/renderer/platform/bindings/script_state.h"
@@ -90,6 +91,7 @@ BaseAudioContext::BaseAudioContext(Document* document,
                                    enum ContextType context_type)
     : PausableObject(document),
       destination_node_(nullptr),
+      uuid_(CreateCanonicalUUIDString()),
       is_cleared_(false),
       is_resolving_resume_promises_(false),
       has_posted_cleanup_task_(false),

diff --git a/third_party/blink/renderer/modules/webaudio/base_audio_context.h b/third_party/blink/renderer/modules/webaudio/base_audio_context.h
@@ -351,9 +351,14 @@ class MODULES_EXPORT BaseAudioContext
   // Returns the Document wich wich the instance is associated.
   Document* GetDocument() const;
 
+  const String& Uuid() const { return uuid_; }
+
  private:
   friend class AudioContextAutoplayTest;
 
+  // Unique ID for each context.
+  const String uuid_;
+
   bool is_cleared_;
   void Clear();