Grid properties should not accept unitless length quirk

The following properties are currently accepting unit lengths in quirks mode, contrary to spec[1]. - grid-auto-columns - grid-auto-rows - grid-template-columns - grid-template-rows so it should disallow. [1]https://quirks.spec.whatwg.org/#the-unitless-length-quirk Bug: 876704 Change-Id: I3af3d01f96efb3b3f788ca02893b12c7ae683c20 Reviewed-on: https://chromium-review.googlesource.com/1190045 Commit-Queue: Eric Willigers <[email protected]> Commit-Queue: Hwanseung Lee <[email protected]> Reviewed-by: Eric Willigers <[email protected]> Cr-Commit-Position: refs/heads/master@{#586513}
feiyue1206 · Aug 28, 2018 · 13c023c · 13c023c
1 parent 87e497f
commit 13c023c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/third_party/WebKit/LayoutTests/external/wpt/quirks/unitless-length/excluded-properties.html b/third_party/WebKit/LayoutTests/external/wpt/quirks/unitless-length/excluded-properties.html
@@ -15,6 +15,10 @@
 
 var properties = [
     'block-size',
+    'grid-auto-columns',
+    'grid-auto-rows',
+    'grid-template-columns',
+    'grid-template-rows',
     'inline-size',
     'margin-block-end',
     'margin-block-start',

diff --git a/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc b/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
@@ -1565,7 +1565,7 @@ CSSValue* ConsumeGridBreadth(CSSParserTokenRange& range,
   }
   return CSSPropertyParserHelpers::ConsumeLengthOrPercent(
       range, css_parser_mode, kValueRangeNonNegative,
-      CSSPropertyParserHelpers::UnitlessQuirk::kAllow);
+      CSSPropertyParserHelpers::UnitlessQuirk::kForbid);
 }
 
 CSSValue* ConsumeFitContent(CSSParserTokenRange& range,