Skip to content

Commit

Permalink
Tracing: Fix bulid ID metadata
Browse files Browse the repository at this point in the history
The build ID was added as const char* metadata which will not be copied.
Explicitly add it as string field so that argument is copied.

BUG=772252

Change-Id: Ie7eae23550af1811b98b9571029d0439cc7d34a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521463
Reviewed-by: oysteine <[email protected]>
Commit-Queue: ssid <[email protected]>
Cr-Commit-Position: refs/heads/master@{#640523}
  • Loading branch information
ssiddhartha authored and Commit Bot committed Mar 13, 2019
1 parent 93dc5df commit 365bbba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/trace_event/trace_log.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1530,7 +1530,7 @@ void TraceLog::AddMetadataEventsWhileLocked() {
base::debug::ReadElfBuildId(&__executable_start, true, build_id);
if (build_id_length > 0) {
AddMetadataEventWhileLocked(current_thread_id, "chrome_library_module",
"id", build_id);
"id", std::string(build_id));
}
#endif

Expand Down

0 comments on commit 365bbba

Please sign in to comment.