Skip to content

Commit

Permalink
Disable wasm in PDF's V8 engine.
Browse files Browse the repository at this point in the history
Since PDFs don't contain webassembly.

Once this lands, we should consider doing the same thing for
the proxy_resolver_v8.cc file as well.

Change-Id: If9e33defb4ea4124eefd6555a5331cfe3f0e22b4
Reviewed-on: https://chromium-review.googlesource.com/c/1321050
Reviewed-by: Chris Palmer <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Jochen Eisinger <[email protected]>
Commit-Queue: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/master@{#606074}
  • Loading branch information
tsepez authored and Commit Bot committed Nov 7, 2018
1 parent 056f900 commit 76b6575
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pdf/pdfium/pdfium_engine.cc
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,9 @@ std::string GetDocumentMetadata(FPDF_DOCUMENT doc, const std::string& key) {
gin::IsolateHolder* g_isolate_holder = nullptr;

void SetUpV8() {
static const char kNoExposeWasm[] = "--no-expose-wasm";
v8::V8::SetFlagsFromString(kNoExposeWasm, strlen(kNoExposeWasm));

gin::IsolateHolder::Initialize(gin::IsolateHolder::kNonStrictMode,
gin::IsolateHolder::kStableV8Extras,
gin::ArrayBufferAllocator::SharedInstance());
Expand Down

0 comments on commit 76b6575

Please sign in to comment.