Skip to content

Commit

Permalink
Enable new-style pixel layout tests always.
Browse files Browse the repository at this point in the history
They are disabled on android forcing us to keep a whole heap of legacy
code around that is not even understandable at this point (the whole
CompositeAndReadbackAsync() path). In order to remove this old code,
which is also dead when Android layout tests aren't running, turn the
new mode on always. If pixel-based Android layout tests are wanted to
run, they should resolve whatever is busted for them in the new path
rather than keeping a whole other compositing mode around just for
them.

I will follow up with CLs to remove the flag once this proof of concept
lands, and to remove all the dead code in RenderWidget, WebTestSupport,
etc.

[email protected]

Bug: 912193
Change-Id: I4bfb14101073ea5086ada901cf618ef1c5d08d2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542229
Reviewed-by: Antoine Labour <[email protected]>
Commit-Queue: danakj <[email protected]>
Cr-Commit-Position: refs/heads/master@{#645315}
  • Loading branch information
danakj authored and Commit Bot committed Mar 28, 2019
1 parent 0d787db commit 7d6a998
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions content/shell/app/shell_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -214,13 +214,7 @@ bool ShellMainDelegate::BasicStartupComplete(int* exit_code) {
command_line.AppendSwitch(cc::switches::kEnableGpuBenchmarking);
command_line.AppendSwitch(switches::kEnableLogging);
command_line.AppendSwitch(switches::kAllowFileAccessFromFiles);
#if !defined(OS_ANDROID)
// TODO(crbug/567947) Enable display compositor pixel dumps for Android
// once testing becomes possible on post-kitkat OSes, and once we've
// had a chance to debug the web test failures that occur when this
// flag is present.
command_line.AppendSwitch(switches::kEnableDisplayCompositorPixelDump);
#endif
// only default to a software GL if the flag isn't already specified.
if (!command_line.HasSwitch(switches::kUseGpuInTests) &&
!command_line.HasSwitch(switches::kUseGL)) {
Expand Down

0 comments on commit 7d6a998

Please sign in to comment.