Skip to content

Commit

Permalink
Reland "Disable NetworkChangeManagerClientBrowserTest.ReconnectToNetw…
Browse files Browse the repository at this point in the history
…orkService"

This is a reland of 8af8547

The original author is [email protected], yhirano replaced DISABLE_ with
DISABLED_.

Original change's description:
> Disable NetworkChangeManagerClientBrowserTest.ReconnectToNetworkService
>
> This test is flaky on ChromeOS when the network service is enabled.
>
> Bug: 934583
> Change-Id: Ib0a37e995a69555b5a5381bdef24f92fd19c12d9
> Reviewed-on: https://chromium-review.googlesource.com/c/1482005
> Reviewed-by: John Abd-El-Malek <[email protected]>
> Commit-Queue: Robbie McElrath <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#634467}

Bug: 934583
Tbr: [email protected]
Change-Id: I87dc76c9e36f25d78279105b03ea9b3340e47718
Reviewed-on: https://chromium-review.googlesource.com/c/1482278
Auto-Submit: Yutaka Hirano <[email protected]>
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Robbie McElrath <[email protected]>
Cr-Commit-Position: refs/heads/master@{#634867}
  • Loading branch information
robbiemc authored and Commit Bot committed Feb 22, 2019
1 parent 1ee41cd commit 97f29e1
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,9 @@ IN_PROC_BROWSER_TEST_F(NetworkChangeManagerClientBrowserTest,

// Tests that the NetworkChangeManagerClient reconnects to the network service
// after it gets disconnected.
// TODO(crbug.com/934583): Fix the flakiness.
IN_PROC_BROWSER_TEST_F(NetworkChangeManagerClientBrowserTest,
ReconnectToNetworkService) {
DISABLED_ReconnectToNetworkService) {
if (!base::FeatureList::IsEnabled(network::features::kNetworkService))
return;

Expand Down

0 comments on commit 97f29e1

Please sign in to comment.