Skip to content

Commit

Permalink
Revert of Disable Precompile-platform with clang-cl. (patchset chromi…
Browse files Browse the repository at this point in the history
…um#1 id:1 of https://codereview.chromium.org/2520833005/ )

Reason for revert:
The crash is now hopefully fixed in clang-cl.

Original issue's description:
> Disable Precompile-platform with clang-cl.
>
> It currently asserts while trying to build that PCH file.
>
> BUG=667891,495697
> NOTRY=true
>
> Committed: https://crrev.com/5b7b04e7fa59d53b8b7917d4c0cf4081abdfb0e3
> Cr-Commit-Position: refs/heads/master@{#434028}

[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=667891,495697

Review-Url: https://codereview.chromium.org/2526383002
Cr-Commit-Position: refs/heads/master@{#434534}
  • Loading branch information
nico authored and Commit bot committed Nov 25, 2016
1 parent e0fa28b commit a0eb8ed
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions third_party/WebKit/Source/core/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ import("//build/config/pch.gni")

config("blink_core_pch") {
if (enable_precompiled_headers) {
# TODO(thakis): Enable for clang once it works, https://crbug.com/667891
if (is_win && !is_clang) {
if (is_win) {
# This is a string rather than a file GN knows about. It has to match
# exactly what's in the /FI flag below, and what might appear in the
# source code in quotes for an #include directive.
Expand Down

0 comments on commit a0eb8ed

Please sign in to comment.