Disable death test in official builds, it fails there

This death test is looking for output from a CHECK failure, and CHECk failures are not printed in official+release builds. This test has been failing on our official clang ToT bot since it was added: https://ci.chromium.org/buildbot/chromium.clang/ToTWin/2132 [email protected],[email protected] Bug: 864640 Change-Id: I7527d65d3ffcfba9a68427aa60d2e6152be838ce Reviewed-on: https://chromium-review.googlesource.com/1217066 Reviewed-by: Doug Arnett <[email protected]> Commit-Queue: Reid Kleckner <[email protected]> Cr-Commit-Position: refs/heads/master@{#590041}
feiyue1206 · Sep 10, 2018 · af6af7e · af6af7e
1 parent 7fc8a7a
commit af6af7e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/components/previews/core/bloom_filter_unittest.cc b/components/previews/core/bloom_filter_unittest.cc
@@ -101,7 +101,8 @@ TEST(BloomFilterTest, EverythingMatches) {
   EXPECT_TRUE(filter.Contains("Echo"));
 }
 
-#if !defined(OS_IOS)
+// Disable this test in configurations that don't print CHECK failures.
+#if !defined(OS_IOS) && !(defined(OFFICIAL_BUILD) && defined(NDEBUG))
 TEST(BloomFilterTest, ByteVectorTooSmall) {
   ByteVector data(1023, 0xff);
   EXPECT_DEATH({ BloomFilter filter(8191 /* num_bits */, data, 7); },