File Manager: Remove inaccurate @extends {cr.EventTarget} annotation.

FileOperationManagerImpl class was falsely reporting to the JS compiler that it is a cr.EventTarget subclass, even though it was not. Bug: 854268 Change-Id: Ib891cbabebeca5fb1475e9a8d0f5037e873a20ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515911 Commit-Queue: Luciano Pacheco <[email protected]> Auto-Submit: Demetrios Papadopoulos <[email protected]> Reviewed-by: Luciano Pacheco <[email protected]> Cr-Commit-Position: refs/heads/master@{#640128}
feiyue1206 · Mar 12, 2019 · f1e1b02 · f1e1b02
1 parent c9bc2ce
commit f1e1b02
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/ui/file_manager/externs/background/file_operation_manager.js b/ui/file_manager/externs/background/file_operation_manager.js
@@ -4,7 +4,8 @@
 
 /**
  * FileOperationManager: manager of file operations. Implementations of this
- * interface must @extends {cr.EventTarget}.
+ * interface must @extends {cr.EventTarget} or implement the EventTarget API on
+ * their own.
  *
  * @interface
  * @extends {EventTarget}

diff --git a/ui/file_manager/file_manager/background/js/file_operation_manager.js b/ui/file_manager/file_manager/background/js/file_operation_manager.js
@@ -8,7 +8,6 @@
  * @constructor
  * @struct
  * @implements {FileOperationManager}
- * @extends {cr.EventTarget}
  */
 function FileOperationManagerImpl() {
   /**
@@ -69,6 +68,12 @@ FileOperationManagerImpl.prototype.removeEventListener = function(
   this.eventRouter_.removeEventListener(type, handler);
 };
 
+/** @override */
+FileOperationManagerImpl.prototype.dispatchEvent = function() {
+  // Not used. Just need this to satisfy the compiler @implements
+  // FileOperationManager interface.
+};
+
 /**
  * Checks if there are any tasks in the queue.
  * @return {boolean} True, if there are any tasks.